TO BE CLOSED: Endpoints to scan user notification and notify users#68
TO BE CLOSED: Endpoints to scan user notification and notify users#68samuzzal-choudhury wants to merge 15 commits intofabric8-analytics:masterfrom
Conversation
samuzzal-choudhury
changed the title
|
[test] |
1 similar comment
|
[test] |
samuzzal-choudhury
force-pushed
the
user_notification
branch
2 times, most recently
from
a9a15cd to
f533d1b
Compare
|
@samuzzal-choudhury Your image is available in the registry: |
1 similar comment
|
@samuzzal-choudhury Your image is available in the registry: |
|
[test] |
|
@samuzzal-choudhury Your image is available in the registry: |
|
[test] |
samuzzal-choudhury
force-pushed
the
user_notification
branch
from
5127128 to
2fb3577
Compare
|
@samuzzal-choudhury Your image is available in the registry: |
|
@samuzzal-choudhury Your image is available in the registry: |
|
@samuzzal-choudhury Your image is available in the registry: |
|
@samuzzal-choudhury Your image is available in the registry: |
|
[test] |
|
@samuzzal-choudhury Your image is available in the registry: |
| secretKeyRef: | ||
| name: aws | ||
| key: s3-secret-access-key | ||
| - name: GEIMINI_SA_CLIENT_ID |
There was a problem hiding this comment.
Looks like a typo here. Should be GEMINI_SA_CLIENT_ID.
|
|
||
| def init_auth_sa_token(): | ||
| """Initialize a service token from auth service.""" | ||
| auth_server_url = getenv('AUTH_SERVICE_HOST', 'https://auth.prod-preview.openshift.io') |
There was a problem hiding this comment.
We shouldn't expose the auth prod-preview url, instead return an empty string '' and check for validity of auth_server_url before proceeding.
| auth_server_url = getenv('AUTH_SERVICE_HOST', 'https://auth.prod-preview.openshift.io') | ||
| endpoint = '{url}/api/token'.format(url=auth_server_url) | ||
|
|
||
| client_id = getenv('GEIMINI_SA_CLIENT_ID', 'id') |
samuzzal-choudhury
changed the title
4 participants
No description provided.