Added support for the --target parameter in the docker build phase#1908
Merged
rohanKanojia merged 2 commits intofabric8io:masterfrom Apr 1, 2026
Merged
Conversation
Member
|
@jacob-netguardians : Could you please rebase against main branch? |
Contributor
Author
|
@rohanKanojia Sure thing. Done. |
…d without buildx) phase Signed-off-by: Jacob Deker <deker@netguardians.ch>
jacob-netguardians
force-pushed
the
feature/support-for-target-parameter
branch
from
356a22a to
da13d35
Compare
Member
|
@jacob-netguardians : Thanks a lot for this! Do you think it's possible to add an integration test for this feature? There are several projects in |
Tests cover both the regular docker build and buildx code paths. Each test builds a multi-stage Dockerfile with --target=base, starts the resulting container, and asserts it outputs "base" (not "final"), confirming the target stage was respected.
Contributor
Author
|
@rohanKanojia I just pushed two new integration tests (one for plain build, the other for buildx). Should I merge the two commits of the branch into one? Do you see anything missing? |
|
rohanKanojia
approved these changes
Apr 1, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added support for the --target parameter in the docker build phase (also with buildx)