Skip to content

fix: Use correct url to get pod logs #7128

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix: Use correct url to get pod logs #7128

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion ...es-client/src/main/java/io/fabric8/kubernetes/client/utils/internal/PodOperationUtil.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -71,7 +71,7 @@ public static List<PodResource> getFilteredPodsForLogs(PodOperationsImpl podOper
public static PodOperationsImpl getGenericPodOperations(OperationContext context, PodOperationContext podOperationContext) {
return new PodOperationsImpl(
podOperationContext,
context.withName(null).withApiGroupName(null).withApiGroupVersion("v1"));
context.withName(null).withItem(null).withApiGroupName(null).withApiGroupVersion("v1"));
}

public static List<PodResource> getPodOperationsForController(OperationContext context,
Expand Down
11 changes: 10 additions & 1 deletion kubernetes-itests/src/test/java/io/fabric8/kubernetes/JobIT.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,7 +40,7 @@ class JobIT {
void testGetLog() {
final String jobName = "job-get-log";
client.batch().v1().jobs().createOrReplace(initJob("job-get-log").build());
client.batch().v1().jobs().withName(jobName).waitUntilCondition(
Job job = client.batch().v1().jobs().withName(jobName).waitUntilCondition(
j -> Optional.ofNullable(j).map(Job::getStatus).map(JobStatus::getSucceeded).orElse(0) > 0,
1, TimeUnit.MINUTES);
ByteArrayOutputStream baos = new ByteArrayOutputStream(1024);
Expand All @@ -52,6 +52,15 @@ void testGetLog() {
assertNotNull(baos.toString());
assertEquals("This is a message!\n", baos.toString());
}
ByteArrayOutputStream baos2 = new ByteArrayOutputStream(1024);
try (LogWatch ignore = client.batch().v1().jobs()
.resource(job)
.withLogWaitTimeout(30)
.watchLog(baos2)) {
await().atMost(30, TimeUnit.SECONDS).until(() -> baos2.toString().length() > 0);
assertNotNull(baos2.toString());
assertEquals("This is a message!\n", baos2.toString());
}
}

@Test
Expand Down