Remove pyre-fixme/pyre-ignore from ax/utils/ source files#4983
Closed
saitcakmak wants to merge 1 commit intofacebook:mainfrom
Closed
Remove pyre-fixme/pyre-ignore from ax/utils/ source files#4983saitcakmak wants to merge 1 commit intofacebook:mainfrom
saitcakmak wants to merge 1 commit intofacebook:mainfrom
Conversation
|
@saitcakmak has exported this pull request. If you are a Meta employee, you can view the originating Diff in D95265024. |
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #4983 +/- ##
=======================================
Coverage 96.83% 96.83%
=======================================
Files 599 599
Lines 64518 64583 +65
=======================================
+ Hits 62473 62536 +63
- Misses 2045 2047 +2 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
) Summary: Remove ~125 pyre-fixme/pyre-ignore suppression comments from 21 source files in ax/utils/ by applying proper type fixes: - Use `none_throws()` for Optional unwrapping (e.g., grad access, sim_start_time) - Use `cast()` for GPyTorch model and FixedFeatureModel narrowing - Fix covariant TypeVar issue in Result.unwrap_or with new TypeVar U - Add proper annotations to StreamHandler[Any], Callable[..., Any] - Use helper functions for dynamic GPyTorch attribute access - Use `np.asarray()` for numpy return type consistency - Fix scipy stub limitations with positional args - Use `record.__dict__` for safe attribute assignment All 100 tests pass (0 failures across 6 test targets). Reviewed By: dme65 Differential Revision: D95265024
a8d4360 to
2d6bc40
Compare
|
This pull request has been merged in 9f50a93. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
Remove ~125 pyre-fixme/pyre-ignore suppression comments from 21 source files
in ax/utils/ by applying proper type fixes:
none_throws()for Optional unwrapping (e.g., grad access, sim_start_time)cast()for GPyTorch model and FixedFeatureModel narrowingnp.asarray()for numpy return type consistencyrecord.__dict__for safe attribute assignmentAll 100 tests pass (0 failures across 6 test targets).
Differential Revision: D95265024