Add NotApplicableStateAnalysisCard class (#5035)#5035
Open
shrutipatel31 wants to merge 1 commit intofacebook:mainfrom
Open
Add NotApplicableStateAnalysisCard class (#5035)#5035shrutipatel31 wants to merge 1 commit intofacebook:mainfrom
shrutipatel31 wants to merge 1 commit intofacebook:mainfrom
Conversation
meta-cla
bot
added
the
CLA Signed
|
@shrutipatel31 has exported this pull request. If you are a Meta employee, you can view the originating Diff in D96248249. |
shrutipatel31
added a commit
to shrutipatel31/Ax
that referenced
this pull request
Mar 16, 2026
Summary: Add a new NotApplicableAnalysisCard class with gray styling to distinguish transient 'not applicable' states from true errors. This card is used for analyses that cannot be computed due to the current experiment state (e.g., 'Experiment has no data yet') but will become available as the experiment progresses. Key features: - Gray styling (#f5f5f5 background, #b0b0b0 border) instead of red - Hourglass icon to indicate transient/waiting state - Info hover tooltip explaining the card type - NOT a subclass of ErrorAnalysisCard (important for filtering logic) This is part 1 of 3 in the NotApplicableAnalysisCard stack. Differential Revision: D96248249
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #5035 +/- ##
==========================================
+ Coverage 96.83% 96.84% +0.01%
==========================================
Files 606 606
Lines 65322 65351 +29
==========================================
+ Hits 63256 63292 +36
+ Misses 2066 2059 -7 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Summary: Add a new NotApplicableStateAnalysisCard class to distinguish transient 'not applicable ' states from true errors. This card is used for analyses that cannot be computed due to the current experiment state (e.g., 'Experiment has no data yet') but will become available as the experiment progresses. Differential Revision: D96248249
meta-codesync
bot
changed the title
shrutipatel31
force-pushed
the
export-D96248249
branch
from
32e3101 to
8460f8a
Compare
shrutipatel31
added a commit
to shrutipatel31/Ax
that referenced
this pull request
Mar 17, 2026
Summary: Add a new NotApplicableStateAnalysisCard class to distinguish transient 'not applicable ' states from true errors. This card is used for analyses that cannot be computed due to the current experiment state (e.g., 'Experiment has no data yet') but will become available as the experiment progresses. Differential Revision: D96248249
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
Add a new NotApplicableStateAnalysisCard class to distinguish
transient 'not applicable ' states from true errors. This card is used for
analyses that cannot be computed due to the current experiment state (e.g.,
'Experiment has no data yet') but will become available as the experiment
progresses.
Differential Revision: D96248249