Add encoder/decoder support for NotApplicableAnalysisCard (#5036)#5036
Open
shrutipatel31 wants to merge 2 commits intofacebook:mainfrom
Open
Add encoder/decoder support for NotApplicableAnalysisCard (#5036)#5036shrutipatel31 wants to merge 2 commits intofacebook:mainfrom
shrutipatel31 wants to merge 2 commits intofacebook:mainfrom
Conversation
meta-cla
bot
added
the
CLA Signed
|
@shrutipatel31 has exported this pull request. If you are a Meta employee, you can view the originating Diff in D96248247. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #5036 +/- ##
==========================================
+ Coverage 96.83% 96.85% +0.01%
==========================================
Files 606 606
Lines 65322 65368 +46
==========================================
+ Hits 63256 63309 +53
+ Misses 2066 2059 -7 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Summary: Add a new NotApplicableStateAnalysisCard class to distinguish transient 'not applicable ' states from true errors. This card is used for analyses that cannot be computed due to the current experiment state (e.g., 'Experiment has no data yet') but will become available as the experiment progresses. Differential Revision: D96248249
) Summary: Add SQA storage support for the new NotApplicableStateAnalysisCard class: - encoder.py: Add NotApplicableStateAnalysisCard check with blob_annotation='not_applicable_state' - decoder.py: Add decoding logic for blob_annotation='not_applicable_state' This allows NotApplicableStateAnalysisCard instances to be saved and loaded from the database correctly. Differential Revision: D96248247
meta-codesync
bot
changed the title
shrutipatel31
force-pushed
the
export-D96248247
branch
from
985535f to
57787c9
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
Add SQA storage support for the new NotApplicableStateAnalysisCard class:
This allows NotApplicableStateAnalysisCard instances to be saved and loaded
from the database correctly.
Differential Revision: D96248247