Route AnalysisNotApplicableStateError to NotApplicableAnalysisCard (#5051)#5051
Closed
shrutipatel31 wants to merge 1 commit intofacebook:mainfrom
Closed
Route AnalysisNotApplicableStateError to NotApplicableAnalysisCard (#5051)#5051shrutipatel31 wants to merge 1 commit intofacebook:mainfrom
shrutipatel31 wants to merge 1 commit intofacebook:mainfrom
Conversation
|
@shrutipatel31 has exported this pull request. If you are a Meta employee, you can view the originating Diff in D96248248. |
meta-cla
bot
added
the
CLA Signed
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #5051 +/- ##
=======================================
Coverage ? 96.30%
=======================================
Files ? 613
Lines ? 67282
Branches ? 0
=======================================
Hits ? 64796
Misses ? 2486
Partials ? 0 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
meta-codesync
bot
changed the title
shrutipatel31
force-pushed
the
export-D96248248
branch
from
9660af1 to
ad9cfbf
Compare
shrutipatel31
added a commit
to shrutipatel31/Ax
that referenced
this pull request
Mar 18, 2026
…acebook#5051) Summary: Update error_card_from_analysis_e() in analysis.py to route AnalysisNotApplicableStateError exceptions to NotApplicableStateAnalysisCard instead of ErrorAnalysisCard. Differential Revision: D96248248
shrutipatel31
added a commit
to shrutipatel31/Ax
that referenced
this pull request
Mar 18, 2026
…acebook#5051) Summary: Update error_card_from_analysis_e() in analysis.py to route AnalysisNotApplicableStateError exceptions to NotApplicableStateAnalysisCard instead of ErrorAnalysisCard. Differential Revision: D96248248
shrutipatel31
force-pushed
the
export-D96248248
branch
from
ad9cfbf to
f1e309a
Compare
shrutipatel31
added a commit
to shrutipatel31/Ax
that referenced
this pull request
Mar 19, 2026
…acebook#5051) Summary: Update error_card_from_analysis_e() in analysis.py to route AnalysisNotApplicableStateError exceptions to NotApplicableStateAnalysisCard instead of ErrorAnalysisCard. Reviewed By: bernardbeckerman Differential Revision: D96248248
shrutipatel31
force-pushed
the
export-D96248248
branch
from
f1e309a to
941bffe
Compare
…acebook#5051) Summary: Update error_card_from_analysis_e() in analysis.py to route AnalysisNotApplicableStateError exceptions to NotApplicableStateAnalysisCard instead of ErrorAnalysisCard. Reviewed By: bernardbeckerman Differential Revision: D96248248
shrutipatel31
force-pushed
the
export-D96248248
branch
from
941bffe to
87ac9df
Compare
|
This pull request has been merged in 4b2905b. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
Update error_card_from_analysis_e() in analysis.py to route AnalysisNotApplicableStateError exceptions to NotApplicableStateAnalysisCard instead of ErrorAnalysisCard.
Reviewed By: bernardbeckerman
Differential Revision: D96248248