Skip to content

tests: e2e: reduce background traffic noise in chain_update_set#452

Merged
qdeslandes merged 1 commit intofacebook:mainfrom
qdeslandes:fix_chain_update_set_test
Mar 3, 2026
Merged

tests: e2e: reduce background traffic noise in chain_update_set#452
qdeslandes merged 1 commit intofacebook:mainfrom
qdeslandes:fix_chain_update_set_test

Conversation

@qdeslandes
Copy link
Contributor

chain_update_set.sh uses pings and rule counters to validate sets are updated as expected. Because the matcher is wide, we sometime fails the test due to background traffic on the NIC. Limit the rule to the existing matchers + ip4.proto icmp to catch on ping traffic.

chain_update_set.sh uses pings and rule counters to validate sets are
updated as expected. Because the matcher is wide, we sometime fails the
test due to background traffic on the NIC. Limit the rule to the
existing matchers + `ip4.proto icmp` to catch on ping traffic.
@meta-cla meta-cla bot added the cla signed label Mar 3, 2026
@github-actions
Copy link

github-actions bot commented Mar 3, 2026

Claude: review of facebook/bpfilter #452 (06a9d87)

Nits

  • Minor grammatical issue in commit body — commit message — The commit body reads "we sometime fails the test" — this should be "we sometimes fail the test" ("sometime" → "sometimes", "fails" → "fail" for subject-verb agreement with "we")

@qdeslandes qdeslandes merged commit 0703e67 into facebook:main Mar 3, 2026
32 checks passed
@qdeslandes qdeslandes deleted the fix_chain_update_set_test branch March 3, 2026 23:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant