Skip to content

lib,daemon,cli,tests,doc,tools: rename cgroup to cgroup_skb#455

Merged
qdeslandes merged 1 commit intofacebook:mainfrom
yaakov-stein:rename_cgroup_with_skb
Mar 4, 2026
Merged

lib,daemon,cli,tests,doc,tools: rename cgroup to cgroup_skb#455
qdeslandes merged 1 commit intofacebook:mainfrom
yaakov-stein:rename_cgroup_with_skb

Conversation

@yaakov-stein
Copy link
Contributor

Renames all instances of CGROUP flavor and hook references to CGROUP_SKB to prepare for adding CGROUP_SOCK_ADDR (#355). Beyond the note below, this should have no functional changes.

Note:

  • This will break serialization and existing external tests that rely on CGROUP hook names (BF_HOOK_CGROUP_SKB_INGRESS, BF_HOOK_CGROUP_SKB_EGRESS)

@yaakov-stein yaakov-stein requested a review from qdeslandes as a code owner March 4, 2026 20:05
@meta-cla meta-cla bot added the cla signed label Mar 4, 2026
@github-actions
Copy link

github-actions bot commented Mar 4, 2026

Claude: review of facebook/bpfilter #455 (4d5ece3)

Must fix

  • Comment not updated from Cgroup to cgroup_skbtests/e2e/rules/redirect.sh:12 — Fixed: comment now says "NF/cgroup_skb hooks"

Suggestions

  • Mixed terminology: cgroup_skb vs CGroup in same sentencedoc/usage/daemon.rst:42 — Fixed: now reads "attach a cgroup_skb chain to the proper cgroup"

@yaakov-stein yaakov-stein force-pushed the rename_cgroup_with_skb branch from 64a0ff8 to 4d5ece3 Compare March 4, 2026 20:16
@qdeslandes qdeslandes merged commit d053cc4 into facebook:main Mar 4, 2026
59 of 60 checks passed
@yaakov-stein yaakov-stein deleted the rename_cgroup_with_skb branch March 4, 2026 23:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants