Skip to content

Temporarily disable zstd bytestream compression #1155

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
dtolnay wants to merge 1 commit into from
Closed

Temporarily disable zstd bytestream compression #1155

dtolnay wants to merge 1 commit into from

Conversation

@dtolnay
Copy link

@dtolnay dtolnay commented Nov 28, 2025

Summary:
Remote execution with BuildBuddy is still impacted by the bug described in #1103 (comment).

Zstd compression can be re-enabled after async-compression has been fixed, potentially by Nullus157/async-compression#400.

Differential Revision: D87992619

@facebook-github-bot
Temporarily disable zstd bytestream compression
e89a097 
Summary:
Remote execution with BuildBuddy is still impacted by the bug described in <facebook#1103 (comment)>.

Zstd compression can be re-enabled after `async-compression` has been fixed, potentially by <Nullus157/async-compression#400>.

Differential Revision: D87992619
@meta-cla meta-cla bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Nov 28, 2025
@meta-codesync
Copy link
Contributor

meta-codesync bot commented Nov 28, 2025

@dtolnay has exported this pull request. If you are a Meta employee, you can view the originating Diff in D87992619.

@cormacrelf
Copy link
Contributor

cormacrelf commented Nov 28, 2025 •
edited
Loading

Did you see? It works with decoder.multiple_members(true);. Just put that in the zstd decoder init, and probably also the gzip one, which will have the same issue. I should have summarised that as the outcome after my long investigation.

@cormacrelf
Copy link
Contributor

cormacrelf commented Nov 28, 2025

While you're there, may as well grep brotli cannot be supported and add brotli support, as the protobufs have been updated. Probably use decoder.multiple_members(true); for that as well.

dtolnay
dtolnay commented Nov 28, 2025
View reviewed changes
Copy link
Author

@dtolnay dtolnay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

Closing in favor of #1156.

@dtolnay dtolnay closed this Nov 28, 2025
@dtolnay dtolnay deleted the export-D87992619 branch November 28, 2025 18:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. fb-exported meta-exported

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@dtolnay @cormacrelf