Skip to content

Comments

Update text alignment for better compatibility and rtl support#10839

Closed
clicktodev wants to merge 1 commit intofacebook:mainfrom
clicktodev:better-rtl-support
Closed

Update text alignment for better compatibility and rtl support#10839
clicktodev wants to merge 1 commit intofacebook:mainfrom
clicktodev:better-rtl-support

Conversation

@clicktodev
Copy link
Contributor

@clicktodev clicktodev commented Jan 14, 2025

Pre-flight checklist

  • I have read the Contributing Guidelines on pull requests.
  • If this is a code change: I have written unit tests and/or added dogfooding pages to fully verify the new behavior.
  • If this is a new API or substantial change: the PR has an accompanying issue (closes #0000) and the maintainers have approved on my working plan.

Motivation

Align text using 'start' and 'end' values to enhance rtl support.

Test Plan

Test links

Deploy preview: https://deploy-preview-10839--docusaurus-2.netlify.app/

Related issues/PRs

@facebook-github-bot facebook-github-bot added the CLA Signed Signed Facebook CLA label Jan 14, 2025
@clicktodev clicktodev changed the title Update text alignment for better compatibility Update text alignment for better compatibility and rtl support Jan 14, 2025
@netlify
Copy link

netlify bot commented Jan 14, 2025

[V2]

Built without sensitive environment variables

Name Link
🔨 Latest commit e05fe8f
🔍 Latest deploy log https://app.netlify.com/sites/docusaurus-2/deploys/67865a9d9dfa550008c1ecc8
😎 Deploy Preview https://deploy-preview-10839--docusaurus-2.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@github-actions
Copy link

⚡️ Lighthouse report for the deploy preview of this PR

URL Performance Accessibility Best Practices SEO Report
/ 🟠 89 🟢 98 🟢 96 🟢 100 Report
/docs/installation 🟠 51 🟢 97 🟢 100 🟢 100 Report
/docs/category/getting-started 🟠 72 🟢 100 🟢 100 🟠 86 Report
/blog 🟠 61 🟢 96 🟢 100 🟠 86 Report
/blog/preparing-your-site-for-docusaurus-v3 🔴 46 🟢 92 🟢 100 🟢 100 Report
/blog/tags/release 🟠 63 🟢 96 🟢 100 🟠 86 Report
/blog/tags 🟠 74 🟢 100 🟢 100 🟠 86 Report

@clicktodev clicktodev changed the title Update text alignment for better compatibility and rtl support Update text alignment for better compatibility Jan 15, 2025
@clicktodev clicktodev changed the title Update text alignment for better compatibility Update text alignment for better compatibility and rtl suport Jan 15, 2025
@clicktodev clicktodev changed the title Update text alignment for better compatibility and rtl suport Update text alignment for better compatibility and rtl support Jan 15, 2025
Copy link
Collaborator

@slorber slorber left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See my comment here, I'm not sure it improves anything, and introduces logical/non-logical inconsistency

facebookincubator/infima#319 (comment)

@clicktodev
Copy link
Contributor Author

same as other pr

@clicktodev clicktodev closed this Jan 16, 2025
@clicktodev clicktodev deleted the better-rtl-support branch January 16, 2025 12:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed Signed Facebook CLA

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants