Skip to content

feat(cli): add serve --no-clean-urls flag#10842

Closed
HD787 wants to merge 1 commit intofacebook:mainfrom
HD787:cleanurls
Closed

feat(cli): add serve --no-clean-urls flag#10842
HD787 wants to merge 1 commit intofacebook:mainfrom
HD787:cleanurls

Conversation

@HD787
Copy link

@HD787 HD787 commented Jan 15, 2025

This flag allows users to pass false to cleanUrls in the servehandler for the serve command as described in #7991

Pre-flight checklist

  • I have read the Contributing Guidelines on pull requests.
  • If this is a code change: I have written unit tests and/or added dogfooding pages to fully verify the new behavior.
  • If this is a new API or substantial change: the PR has an accompanying issue (closes #0000) and the maintainers have approved on my working plan.

Motivation

Test Plan

Test links

Deploy preview: https://deploy-preview-_____--docusaurus-2.netlify.app/

Related issues/PRs

fix #7991

@facebook-github-bot facebook-github-bot added the CLA Signed Signed Facebook CLA label Jan 15, 2025
@netlify
Copy link

netlify bot commented Jan 15, 2025

[V2]

Built without sensitive environment variables

Name Link
🔨 Latest commit c16095b
🔍 Latest deploy log https://app.netlify.com/sites/docusaurus-2/deploys/67882e92f450cd00088503e5
😎 Deploy Preview https://deploy-preview-10842--docusaurus-2.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@github-actions
Copy link

⚡️ Lighthouse report for the deploy preview of this PR

URL Performance Accessibility Best Practices SEO Report
/ 🟠 70 🟢 98 🟢 96 🟢 100 Report
/docs/installation 🟠 50 🟢 97 🟢 100 🟢 100 Report
/docs/category/getting-started 🟠 72 🟢 100 🟢 100 🟠 86 Report
/blog 🟠 60 🟢 96 🟢 100 🟠 86 Report
/blog/preparing-your-site-for-docusaurus-v3 🔴 46 🟢 92 🟢 100 🟢 100 Report
/blog/tags/release 🟠 63 🟢 96 🟢 100 🟠 86 Report
/blog/tags 🟠 73 🟢 100 🟢 100 🟠 86 Report

@HD787 HD787 changed the title feat(cli): add --no-clean-urls flag feat(cli): add serve --no-clean-urls flag Jan 16, 2025
@slorber
Copy link
Collaborator

slorber commented Jan 16, 2025

Thanks for the PR @HD787

I tested it and unfortunately, I don't think we should proceed with this feature considering it breaks the hosting behavior of a regular Docusaurus site.

See my comment here: #7991 (comment)

@slorber slorber closed this Jan 16, 2025
@slorber slorber added the closed: wontfix A fix will bring significant overhead, or is out of scope (for feature requests) label Jan 16, 2025
@HD787 HD787 deleted the cleanurls branch January 17, 2025 20:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed Signed Facebook CLA closed: wontfix A fix will bring significant overhead, or is out of scope (for feature requests)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Allow configuration of cleanUrls option for serve command

3 participants