feat(core): promote siteConfig.storage to stable + add future.v4.siteStorageNamespacing flag [Codex]#11798
Closed
feat(core): promote siteConfig.storage to stable + add future.v4.siteStorageNamespacing flag [Codex]#11798
siteConfig.storage to stable + add future.v4.siteStorageNamespacing flag [Codex]#11798Conversation
slorber
changed the title
siteConfig.storage to stable + add future.v4.siteStorageNamespacing flag [Codex]
✅ [V2]
To edit notification comments on pull requests, go to your Netlify project configuration. |
|
Size Change: +2.12 kB (+0.02%) Total Size: 11.9 MB
ℹ️ View Unchanged
|
⚡️ Lighthouse report for the deploy preview of this PR
|
|
Size Change: +1.05 kB (+0.01%) Total Size: 12.3 MB
ℹ️ View Unchanged
|
slorber
commented
Mar 12, 2026
packages/docusaurus/src/server/__tests__/configValidation.test.ts
Outdated
Show resolved
Hide resolved
Collaborator
Author
|
Addressed all review comments in
Validated with:
|
slorber
commented
Mar 12, 2026
slorber
commented
Mar 12, 2026
slorber
commented
Mar 12, 2026
packages/docusaurus/src/server/__tests__/configValidation.test.ts
Outdated
Show resolved
Hide resolved
slorber
commented
Mar 12, 2026
packages/docusaurus/src/server/__tests__/configValidation.test.ts
Outdated
Show resolved
Hide resolved
slorber
commented
Mar 12, 2026
packages/docusaurus/src/server/__tests__/configValidation.test.ts
Outdated
Show resolved
Hide resolved
slorber
commented
Mar 12, 2026
slorber
commented
Mar 12, 2026
…space lookup (AI-assisted)
…cing defaults (AI-assisted)
Collaborator
Author
|
Both AI-generated PRs are in a good and quite similar state now, but I think I prefer working with Claude Code than Codex for now. I'll keep using both in different tasks to understand better the tradeoffs of each |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
(AI-assisted)
Summary
This promotes the storage API to stable and removes the legacy experimental config now that the feature from #10121 is implemented.
future.experimental_storagefrom runtime config schema, types, and current docs.storagewith the sametypeandnamespaceoptions.future.experimental_storageis used, with a clear migration message to use top-levelstorage.future.v4.siteStorageNamespacing(defaultfalse, enabled byfuture.v4: true).future.v4.siteStorageNamespacingis enabled andstorage.namespaceis unset, the default now becomestrue.storage.Tests
future.experimental_storagethrows a clear errorstorageis acceptedfuture.v4.siteStorageNamespacingis validatedfuture.v4.siteStorageNamespacingchanges the default behavior ofstorage.namespaceCommand run:
yarn test packages/docusaurus/src/server/__tests__/configValidation.test.ts packages/docusaurus/src/server/__tests__/storage.test.ts packages/docusaurus/src/server/__tests__/config.test.ts packages/docusaurus/src/server/__tests__/site.test.ts -u