Skip to content

Normalize country (ISO 3166-1) and currency (ISO 4217) properly #714

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
dnikolayev wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Normalize country (ISO 3166-1) and currency (ISO 4217) properly #714

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions facebook_business/adobjects/serverside/normalize.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -78,15 +78,15 @@ def normalize(field, data, hash_field):

elif field == "country":
# Remove any non-alpha characters from the data
normalized_data = isocode_included_chars.sub("", normalized_data)
normalized_data = isocode_included_chars.sub("", normalized_data).upper()
if not Normalize.is_valid_country_code(normalized_data):
raise TypeError("Invalid format for country:'" + data + "'.Please follow ISO 2-letter ISO 3166-1 standard for representing country. eg: us")
raise TypeError("Invalid format for country:'" + data + "'.Please follow ISO 2-letter ISO 3166-1 standard for representing country. eg: US")

elif field == "currency":
# Remove any non-alpha characters from the data
normalized_data = isocode_included_chars.sub("", normalized_data)
normalized_data = isocode_included_chars.sub("", normalized_data).upper()
if len(normalized_data) != 3:
raise TypeError("Invalid format for currency:'" + data + "'.Please follow ISO 3-letter ISO 4217 standard for representing currency. Eg: usd")
raise TypeError("Invalid format for currency:'" + data + "'.Please follow ISO 3-letter ISO 4217 standard for representing currency. Eg: USD")

elif field == "ph":
# Remove spaces and parenthesis within phone number
Expand Down