Skip to content

Fixed missing dll and issues with WebGL #160

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Fixed missing dll and issues with WebGL #160

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f419dd0
Added building and copying of missing Facebook.Unity.Canvas.dll to Un…
Apr 24, 2018
309ae82
Fixes to Login and LogAppEvent
May 3, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 13 additions & 4 deletions Facebook.Unity.Canvas/CanvasJSWrapper.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46,7 +46,10 @@ public void Init(string connectFacebookUrl, string locale, int debug, string ini

public void Login(IEnumerable<string> scope, string callback_id)
{
login(scope, callback_id);
var scopeList = new List<string>(scope);
var scopeListJson = MiniJSON.Json.Serialize(scope);

login(scopeListJson, callback_id);
}

public void Logout() {
Expand All @@ -58,7 +61,10 @@ public void ActivateApp() {
}

public void LogAppEvent(string eventName, float? valueToSum, string parameters) {
logAppEvent(eventName, valueToSum, parameters);
if (valueToSum.HasValue)
logAppEvent(eventName, valueToSum.Value, parameters);
else
logAppEventWithoutValue(eventName, parameters);
}

public void LogPurchase(float purchaseAmount, string currency, string parameters) {
Expand All @@ -77,7 +83,7 @@ public void InitScreenPosition() {
private static extern void init(string connectFacebookUrl, string locale, int debug, string initParams, int status);

[DllImport("__Internal")]
private static extern void login(IEnumerable<string> scope, string callback_id);
private static extern void login(string scope, string callback_id);

[DllImport("__Internal")]
private static extern void logout();
Expand All @@ -86,7 +92,10 @@ public void InitScreenPosition() {
private static extern void activateApp();

[DllImport("__Internal")]
private static extern void logAppEvent(string eventName, float? valueToSum, string parameters);
private static extern void logAppEvent(string eventName, float valueToSum, string parameters);

[DllImport("__Internal")]
private static extern void logAppEventWithoutValue(string eventName, string parameters);

[DllImport("__Internal")]
private static extern void logPurchase(float purchaseAmount, string currency, string parameters);
Expand Down
Loading