Fix #712 by removing FixColdStart()

[xTheEc0]

Thanks for proposing a pull request!

To help us review the request, please complete the following:

• [ X] sign contributor license agreement
• [ X] I've ensured that all existing tests pass and added tests (when/where necessary)
• [ X] I've updated the documentation (when/where necessary) and Changelog (when/where necessary)
• [ X] I've added the proper label to this pull request (e.g. bug for bug fixes)

Pull Request Details

Due to Unity trampoline changes this is now misbehaving and modifying one function below (isBackgroundLaunchOptions) which causes a crash - see #712

Test Plan

Test Plan: Add your test plan here

[facebook-github-bot]

Hi @xTheEc0!

Thank you for your pull request and welcome to our community.

Action Required

In order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you.

Process

In order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with CLA signed. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.

If you have received this in error or have any questions, please contact us at [email protected]. Thanks!

[daniel-scply]

Very good find!! I think you need to also remove the call in FacebookPostprocess:

facebook-sdk-for-unity/Facebook.Unity.Editor/FacebookPostprocess.cs

Line 71 in 9abd766

FixupFiles.FixColdStart(path);

[keitanxkeitan]

Thank you for fixing the issue! When is this fixed supposed to be merged?

[vladyslav-androshchuk]

We have the same problem, it requires us to modify UnityAppController with crunch to fix this issue. Quite important for us.

[d-fofanov]

We're facing the same problem.
I wonder if there's any information on merge-release ETAs?

[hawkhoang]

@xTheEc0 Thanks for the finding. Could this be merged? I think you need to sign the CLA link