Skip to content

Conversation

@manugildev
Copy link

@manugildev manugildev commented Mar 31, 2025

To help us review the request, please complete the following:

  • sign contributor license agreement
  • I've ensured that all existing tests pass and added tests (when/where necessary)
  • I've updated the documentation (when/where necessary) and Changelog (when/where necessary)
  • I've added the proper label to this pull request (e.g. bug for bug fixes)

Pull Request Details

Unity renamed the default AndroidManifest.xml to UnityManifest.xml in 2019.3. This hasn't been updated in this repo, what causes issues extra steps when trying to configure the Facebook SDK, specially in Unity-6 with the new GameActivity application entry.

image

Test Plan

Test Plan:

  1. Enable GameActivity as ApplicationEntry in your Android PlayerSettings
  2. Add facebook sdk to your project
  3. Click Regenerate Android Manifest on the Facebook Settings
  4. See that the generated manifest inside Plugins/Android is based on the old facebook provided DefaultAndroidManifest.xml, instead of the one coming from Unity.
  5. Running the app will fail with error: MAIN + LAUNCHER not found in any activity of your AndroidManifest

After this PR, the issue does not happen.

 - Unity rename the default AndroidManifest.xml to UnityManifest.xml in 2019.3. This hasn't been updated what causes issues extra steps when trying to configure the Facebook SDK, specially in Unity-6 with the new GameActivity application entry.
@manugildev manugildev marked this pull request as ready for review March 31, 2025 14:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants