[Nexthop] Enable Distro Image btrfs boot#1004
Open
travisb-nexthop wants to merge 1 commit intofacebook:mainfrom
Open
[Nexthop] Enable Distro Image btrfs boot#1004travisb-nexthop wants to merge 1 commit intofacebook:mainfrom
travisb-nexthop wants to merge 1 commit intofacebook:mainfrom
Conversation
This change was supposed to have been part of facebook#780 but got missed somehow. It enables the already-added editbootinstall.sh script which modifies the upstream CentOS Grub installer to support booting directly off btrfs partitions instead of needing an initial non-btrfs /boot partition.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pre-submission checklist
pip install -r requirements-dev.txt && pre-commit installpre-commit runSummary
This change was supposed to have been part of
#780 but got missed somehow.
It enables the already-added editbootinstall.sh script which modifies
the upstream CentOS Grub installer to support booting directly off
btrfs partitions instead of needing an initial non-btrfs /boot
partition.
Test Plan
This has been in our produced and shared distro images for months.