[Cisco][G200] [Srv6] Fix to Extend the IPv4 makeUDPTxPacket API to support ECN#1008
Open
itskittycisco wants to merge 1 commit intofacebook:mainfrom
Open
[Cisco][G200] [Srv6] Fix to Extend the IPv4 makeUDPTxPacket API to support ECN#1008itskittycisco wants to merge 1 commit intofacebook:mainfrom
itskittycisco wants to merge 1 commit intofacebook:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pre-submission checklist
pip install -r requirements-dev.txt && pre-commit installpre-commit runclang-format.............................................................Passed
shellcheck...........................................(no files to check)Skipped
shfmt................................................(no files to check)Skipped
trim trailing whitespace.................................................Passed
fix end of files.........................................................Passed
check yaml...........................................(no files to check)Skipped
check json...........................................(no files to check)Skipped
check for merge conflicts................................................Passed
ruff check...........................................(no files to check)Skipped
ruff format..........................................(no files to check)Skipped
Summary
For SRv6 encapsulation in UNIFORM mode, inner IPv4 packets must carry both DSCP and ECN so they can be copied to the outer IPv6 header. The IPv4 makeUDPTxPacket API only set DSCP and never set ECN, so ECN was always 0 in inner IPv4 packets.
Solution:
Add an ecn parameter to the IPv4 makeUDPTxPacket overload.
In the generic makeUDPTxPacket(folly::IPAddress, ...) path, split the full ToS byte into DSCP and ECN when building IPv4 packets.
Update SRv6 encap tests to assert ECN and DSCP propagation in the outer header.
Test Plan