[Nexthop] Fixup Distro Image service dependencies#999
Open
travisb-nexthop wants to merge 1 commit intofacebook:mainfrom
Open
[Nexthop] Fixup Distro Image service dependencies#999travisb-nexthop wants to merge 1 commit intofacebook:mainfrom
travisb-nexthop wants to merge 1 commit intofacebook:mainfrom
Conversation
Avoid succeeding through retries. fboss_init uses weutil to produce fruid.json. weutil first requires that platform_manager is up so it can access the EEPROMs via the devmap. Thus here we fix the dependency order and make platform_manager a hard dependency of fboss_init. qsfp_service gets a similar treatment with fboss_init so it had fruid.json available at the first start.
kevin645
reviewed
Mar 16, 2026
...e/image_builder/templates/centos-09.0/root_files/usr/lib/systemd/system/qsfp_service.service
Show resolved
Hide resolved
Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pre-submission checklist
pip install -r requirements-dev.txt && pre-commit installpre-commit runSummary
Avoid service startup succeeding through retries.
fboss_init uses weutil to produce fruid.json. weutil first requires that platform_manager is up so it can access the EEPROMs via the devmap.
Thus here we fix the dependency order and make platform_manager a hard dependency of fboss_init.
qsfp_service gets a similar treatment with fboss_init so it had fruid.json available at the first start.
Test Plan
See that the services start up reliably when booting Distro Image. Without this change, the FBOSS services and agents would occasionally fail to load when the retry timing did not line up.