Skip to content

Commit 46b3fd0

Browse files
quark-zjufacebook-github-bot
authored andcommitted
iobuf: drop dependency to minibytes
Summary: See previous change for context. This drops the motivation to move `minibytes` to `folly`, surfaced from sapling discord channel: > quark — 1:16 PM > What's the motivation behind moving minibytes? I actually prefer it being part of sapling/ for clearer ownership. > > benrogers — 2:02 PM > https://github.com/search?q=repo%3Afacebook%2Ffolly%20minibytes&type=code > (iobuf is already in folly and depends on minibytes, so moving minibytes there avoids a circular dependency) Switching the dependency (minibytes optionally depend on iobuf) is not easy, because iobuf does not yet have a Cargo.toml, or if it does, it is cross-repo, and if minibytes uses a git url to refer to iobuf, the git url will prevent us from publishing minibytes to creates.io. Reviewed By: muirdm Differential Revision: D79678310 fbshipit-source-id: f87765a280d6fcef4528eb3555cb1027b8193628
1 parent b1b0d26 commit 46b3fd0

File tree

2 files changed

+0
-6
lines changed

2 files changed

+0
-6
lines changed

folly/rust/iobuf/BUCK

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -88,9 +88,6 @@ fb_xplat_rust_library(
8888
crate = "iobuf",
8989
crate_root = "src/lib.rs",
9090
cxx_bridge = "src/lib.rs",
91-
features = [
92-
"minibytes",
93-
],
9491
platforms = (CXX, ANDROID, APPLE, WINDOWS),
9592
test_deps = [
9693
"fbsource//third-party/rust:quickcheck",
@@ -102,7 +99,6 @@ fb_xplat_rust_library(
10299
],
103100
xplat_preexisting_target_flavors = [FBCODE],
104101
deps = [
105-
"fbcode//eden/scm/lib/minibytes:minibytes",
106102
"fbsource//third-party/rust:bytes",
107103
"fbsource//third-party/rust:cxx",
108104
"fbsource//third-party/rust:memmap2",

folly/rust/iobuf/src/iobuf.rs

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -163,8 +163,6 @@ pub unsafe trait BytesToIOBufSharedExt: std::ops::Deref<Target = [u8]> {}
163163

164164
unsafe impl BytesToIOBufSharedExt for bytes::Bytes {}
165165
unsafe impl BytesToIOBufSharedExt for memmap2::Mmap {}
166-
#[cfg(feature = "minibytes")]
167-
unsafe impl BytesToIOBufSharedExt for minibytes::Bytes {}
168166

169167
/// Convert a `Bytes` into an `IOBufShared`.
170168
impl<T> From<T> for IOBufShared

0 commit comments

Comments
 (0)