Skip to content

Commit 3448ce1

Browse files
Veeren Mandaliafacebook-github-bot
authored andcommitted
isInDiskCache operation unknown will use dynamic size based on MC
Reviewed By: defHLT Differential Revision: D66241837 fbshipit-source-id: d576d74108df7108a93dbc9541781f2279e1ea50
1 parent 9be22e8 commit 3448ce1

File tree

3 files changed

+11
-2
lines changed

3 files changed

+11
-2
lines changed

vito/core/src/main/java/com/facebook/fresco/vito/core/DefaultFrescoVitoConfig.kt

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -48,6 +48,8 @@ constructor(override val prefetchConfig: PrefetchConfig = DefaultPrefetchConfig(
4848

4949
override fun experimentalDynamicSizeDiskCacheCheckTimeoutMs(): Long = 0
5050

51+
override fun experimentalDynamicSizeUseSfOnDiskCacheTimeout(): Boolean = false
52+
5153
override fun isAppStarting(): Boolean = false
5254

5355
override fun experimentalDynamicSizeDisableWhenAppIsStarting(): Boolean = false

vito/core/src/main/java/com/facebook/fresco/vito/core/FrescoVitoConfig.kt

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -45,6 +45,8 @@ interface FrescoVitoConfig {
4545

4646
fun experimentalDynamicSizeDiskCacheCheckTimeoutMs(): Long
4747

48+
fun experimentalDynamicSizeUseSfOnDiskCacheTimeout(): Boolean
49+
4850
fun isAppStarting(): Boolean
4951

5052
fun experimentalDynamicSizeDisableWhenAppIsStarting(): Boolean

vito/litho/src/main/java/com/facebook/fresco/vito/litho/FrescoVitoImage2Spec.kt

Lines changed: 7 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -192,8 +192,13 @@ object FrescoVitoImage2Spec {
192192
requestCachedValue,
193193
FrescoVitoProvider.getConfig().experimentalDynamicSizeDiskCacheCheckTimeoutMs(),
194194
TimeUnit.MILLISECONDS)
195-
// Force keep original size if in disk cache OR unknown result (null)
196-
forceKeepOriginalSize.set(isInDiskCache != false)
195+
if (isInDiskCache == null) {
196+
// On timeout, force keep original size by default
197+
forceKeepOriginalSize.set(
198+
!FrescoVitoProvider.getConfig().experimentalDynamicSizeUseSfOnDiskCacheTimeout())
199+
} else {
200+
forceKeepOriginalSize.set(isInDiskCache)
201+
}
197202
}
198203
if (forceKeepOriginalSize.get() == true) {
199204
// Tell image pipeline that we're using an unmodified URL so it can ensure we can prefetch

0 commit comments

Comments
 (0)