Fix freeze/seal on lazy function objects#1933
Open
Kenaz123 wants to merge 1 commit intofacebook:static_hfrom
Open
Fix freeze/seal on lazy function objects#1933Kenaz123 wants to merge 1 commit intofacebook:static_hfrom
Kenaz123 wants to merge 1 commit intofacebook:static_hfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fix
Object.freeze()/Object.seal()on lazy function objects.Before this change,
JSObject::freeze()andJSObject::seal()could mark a lazy function object as frozen/sealed before its lazy properties were materialized. Later, lazy initialization would still add properties likelengthandname, leaving them configurable on an object that already reported itself as frozen.The problematic code path was that
seal()/freeze()did not initialize lazy objects first:This change fixes that by forcing lazy initialization before the object is marked non-extensible and before the hidden class flags are updated.
poc.js
Original PoC reproduction:
Original output before the fix:
Test Plan
check-hermesresult: