Fix proxy defineProperty descriptors to omit absent fields#1936
Open
Kenaz123 wants to merge 2 commits intofacebook:static_hfrom
Open
Fix proxy defineProperty descriptors to omit absent fields#1936Kenaz123 wants to merge 2 commits intofacebook:static_hfrom
Kenaz123 wants to merge 2 commits intofacebook:static_hfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fix proxy
definePropertydescriptor conversion to omit absent fields.Before this change,
objectFromPropertyDescriptor()inlib/VM/Operations.cppwould materialize some descriptor fields unconditionally based on descriptor kind, instead of only emitting fields that were actually present in the inputproperty descriptor.
For data descriptors, it always emitted
value, even when[[Value]]was not present:For accessor descriptors, it always emitted both
getandset, even when one side was absent:That is incorrect for forwarding proxies. When a proxy
definePropertytrap receives a descriptor object, absent fields must stay absent. Emitting them unconditionally changes semantics:set: undefinedand silently remove an existing setter.value: undefinedand silently clobber an existing property value.This change fixes both cases by only emitting
value,get, andsetwhen their correspondingDefinePropertyFlagsbits are set.accessor-poc.js
Original accessor PoC reproduction:
Original accessor output before the fix:
value-poc.js
Original value PoC reproduction:
Original value output before the fix:
Test Plan
Observed results: