Disable DefaultGet generation by default

Summary:
Disable `DefaultGet` method generation by default.
This improves compilation speed for 99.9% of users (except for two schemas that still rely on this deprecated method).

Reviewed By: a-lafrance

Differential Revision: D74601226

fbshipit-source-id: 5464a5368b3530e7b2269ad4bdf60b74c93915ed

Author: echistyakov

third-party/thrift/src/thrift/compiler/generate/go/util.h

@@ -43,7 +43,7 @@ class codegen_data {
   // whether to generate Thrift metadata
   bool gen_metadata = true;
   // whether to generate DefaultGet method
-  bool gen_default_get = true;
+  bool gen_default_get = false;
   // whether to use reflect codec
   bool use_reflect_codec = false;
 

third-party/thrift/src/thrift/compiler/test/fixtures/adapter/out/go/gen-go/module/types.go

@@ -3295,45 +3295,10 @@ func (x *Bar) readField7(p thrift.Decoder) error {  // AdaptedStructField
     return nil
 }
 
-// Deprecated: Use NewBar().GetStructField() instead.
-func (x *Bar) DefaultGetStructField() *Foo_6868 {
-    if !x.IsSetStructField() {
-        return NewFoo_6868()
-    }
-    return x.StructField
-}
 
-// Deprecated: Use NewBar().GetOptionalStructField() instead.
-func (x *Bar) DefaultGetOptionalStructField() *Foo_3943 {
-    if !x.IsSetOptionalStructField() {
-        return NewFoo_3943()
-    }
-    return x.OptionalStructField
-}
 
-// Deprecated: Use NewBar().GetUnionField() instead.
-func (x *Bar) DefaultGetUnionField() *Baz_7352 {
-    if !x.IsSetUnionField() {
-        return NewBaz_7352()
-    }
-    return x.UnionField
-}
 
-// Deprecated: Use NewBar().GetOptionalUnionField() instead.
-func (x *Bar) DefaultGetOptionalUnionField() *Baz_7352 {
-    if !x.IsSetOptionalUnionField() {
-        return NewBaz_7352()
-    }
-    return x.OptionalUnionField
-}
 
-// Deprecated: Use NewBar().GetAdaptedStructField() instead.
-func (x *Bar) DefaultGetAdaptedStructField() *DirectlyAdapted {
-    if !x.IsSetAdaptedStructField() {
-        return NewDirectlyAdapted()
-    }
-    return x.AdaptedStructField
-}
 
 
 
@@ -4268,13 +4233,6 @@ func (x *B) readField1(p thrift.Decoder) error {  // A
     return nil
 }
 
-// Deprecated: Use NewB().GetA() instead.
-func (x *B) DefaultGetA() *AdaptedA {
-    if !x.IsSetA() {
-        return NewAdaptedA()
-    }
-    return x.A
-}
 
 
 
@@ -6725,13 +6683,6 @@ func (x *AdaptTemplatedNestedTestStruct) readField1(p thrift.Decoder) error {  /
     return nil
 }
 
-// Deprecated: Use NewAdaptTemplatedNestedTestStruct().GetAdaptedStruct() instead.
-func (x *AdaptTemplatedNestedTestStruct) DefaultGetAdaptedStruct() *AdaptTemplatedTestStruct {
-    if !x.IsSetAdaptedStruct() {
-        return NewAdaptTemplatedTestStruct()
-    }
-    return x.AdaptedStruct
-}
 
 
 
@@ -7468,37 +7419,9 @@ func (x *StructFieldAdaptedStruct) readField4(p thrift.Decoder) error {  // Type
     return nil
 }
 
-// Deprecated: Use NewStructFieldAdaptedStruct().GetAdaptedStruct() instead.
-func (x *StructFieldAdaptedStruct) DefaultGetAdaptedStruct() *AdaptedStruct {
-    if !x.IsSetAdaptedStruct() {
-        return NewAdaptedStruct()
-    }
-    return x.AdaptedStruct
-}
 
-// Deprecated: Use NewStructFieldAdaptedStruct().GetAdaptedTypedef() instead.
-func (x *StructFieldAdaptedStruct) DefaultGetAdaptedTypedef() *AdaptedTypedef {
-    if !x.IsSetAdaptedTypedef() {
-        return NewAdaptedTypedef()
-    }
-    return x.AdaptedTypedef
-}
 
-// Deprecated: Use NewStructFieldAdaptedStruct().GetDirectlyAdapted() instead.
-func (x *StructFieldAdaptedStruct) DefaultGetDirectlyAdapted() *DirectlyAdaptedStruct {
-    if !x.IsSetDirectlyAdapted() {
-        return NewDirectlyAdaptedStruct()
-    }
-    return x.DirectlyAdapted
-}
 
-// Deprecated: Use NewStructFieldAdaptedStruct().GetTypedefOfAdapted() instead.
-func (x *StructFieldAdaptedStruct) DefaultGetTypedefOfAdapted() *TypedefOfDirect {
-    if !x.IsSetTypedefOfAdapted() {
-        return NewTypedefOfDirect()
-    }
-    return x.TypedefOfAdapted
-}
 
 
 
@@ -7649,13 +7572,6 @@ func (x *CircularAdaptee) readField1(p thrift.Decoder) error {  // Field
     return nil
 }
 
-// Deprecated: Use NewCircularAdaptee().GetField() instead.
-func (x *CircularAdaptee) DefaultGetField() *CircularStruct {
-    if !x.IsSetField() {
-        return NewCircularStruct()
-    }
-    return x.Field
-}
 
 
 
@@ -7788,13 +7704,6 @@ func (x *CircularStruct) readField1(p thrift.Decoder) error {  // Field
     return nil
 }
 
-// Deprecated: Use NewCircularStruct().GetField() instead.
-func (x *CircularStruct) DefaultGetField() *AdaptedCircularAdaptee {
-    if !x.IsSetField() {
-        return NewAdaptedCircularAdaptee()
-    }
-    return x.Field
-}
 
 
 
@@ -7926,13 +7835,6 @@ func (x *ReorderedStruct) readField1(p thrift.Decoder) error {  // ReorderedDepe
     return nil
 }
 
-// Deprecated: Use NewReorderedStruct().GetReorderedDependentAdapted() instead.
-func (x *ReorderedStruct) DefaultGetReorderedDependentAdapted() *DeclaredAfterStruct {
-    if !x.IsSetReorderedDependentAdapted() {
-        return NewDeclaredAfterStruct()
-    }
-    return x.ReorderedDependentAdapted
-}
 
 
 
@@ -8447,13 +8349,6 @@ func (x *MoveOnly) readField1(p thrift.Decoder) error {  // Ptr
     return nil
 }
 
-// Deprecated: Use NewMoveOnly().GetPtr() instead.
-func (x *MoveOnly) DefaultGetPtr() *HeapAllocated {
-    if !x.IsSetPtr() {
-        return NewHeapAllocated()
-    }
-    return x.Ptr
-}
 
 
 
@@ -9541,13 +9436,6 @@ func (x *reqServiceFunc) readField3(p thrift.Decoder) error {  // Arg3
     return nil
 }
 
-// Deprecated: Use newReqServiceFunc().GetArg3() instead.
-func (x *reqServiceFunc) DefaultGetArg3() *Foo {
-    if !x.IsSetArg3() {
-        return NewFoo()
-    }
-    return x.Arg3
-}
 
 
 
@@ -9910,13 +9798,6 @@ func (x *respAdapterServiceCount) readField0(p thrift.Decoder) error {  // Succe
     return nil
 }
 
-// Deprecated: Use newRespAdapterServiceCount().GetSuccess() instead.
-func (x *respAdapterServiceCount) DefaultGetSuccess() *CountingStruct {
-    if !x.IsSetSuccess() {
-        return NewCountingStruct()
-    }
-    return x.Success
-}
 
 
 
@@ -10055,13 +9936,6 @@ func (x *reqAdapterServiceAdaptedTypes) readField1(p thrift.Decoder) error {  //
     return nil
 }
 
-// Deprecated: Use newReqAdapterServiceAdaptedTypes().GetArg() instead.
-func (x *reqAdapterServiceAdaptedTypes) DefaultGetArg() *HeapAllocated {
-    if !x.IsSetArg() {
-        return NewHeapAllocated()
-    }
-    return x.Arg
-}
 
 
 
@@ -10198,13 +10072,6 @@ func (x *respAdapterServiceAdaptedTypes) readField0(p thrift.Decoder) error {  /
     return nil
 }
 
-// Deprecated: Use newRespAdapterServiceAdaptedTypes().GetSuccess() instead.
-func (x *respAdapterServiceAdaptedTypes) DefaultGetSuccess() *HeapAllocated {
-    if !x.IsSetSuccess() {
-        return NewHeapAllocated()
-    }
-    return x.Success
-}
 
 
 

third-party/thrift/src/thrift/compiler/test/fixtures/basic-annotations/out/go/gen-go/module/types.go

@@ -842,13 +842,6 @@ func (x *MyStruct) readField9(p thrift.Decoder) error {  // MyUnion
     return nil
 }
 
-// Deprecated: Use NewMyStruct().GetMyUnion() instead.
-func (x *MyStruct) DefaultGetMyUnion() *MyUnion {
-    if !x.IsSetMyUnion() {
-        return NewMyUnion()
-    }
-    return x.MyUnion
-}
 
 
 
@@ -1276,13 +1269,6 @@ func (x *respMyServicePing) readField1(p thrift.Decoder) error {  // MyExcept
     return nil
 }
 
-// Deprecated: Use newRespMyServicePing().GetMyExcept() instead.
-func (x *respMyServicePing) DefaultGetMyExcept() *MyException {
-    if !x.IsSetMyExcept() {
-        return NewMyException()
-    }
-    return x.MyExcept
-}
 
 
 

third-party/thrift/src/thrift/compiler/test/fixtures/basic/out/go/gen-go/module/types.go

@@ -586,13 +586,6 @@ func (x *MyStruct) readField9(p thrift.Decoder) error {  // NoHackCodegenField
     return nil
 }
 
-// Deprecated: Use NewMyStruct().GetMyDataField() instead.
-func (x *MyStruct) DefaultGetMyDataField() *MyDataItemAlias {
-    if !x.IsSetMyDataField() {
-        return NewMyDataItemAlias()
-    }
-    return x.MyDataField
-}
 
 
 
@@ -1371,21 +1364,7 @@ func (x *MyUnion) readField4(p thrift.Decoder) error {  // FloatSet
 }
 
 
-// Deprecated: Use NewMyUnion().GetMyStruct() instead.
-func (x *MyUnion) DefaultGetMyStruct() *MyStruct {
-    if !x.IsSetMyStruct() {
-        return NewMyStruct()
-    }
-    return x.MyStruct
-}
 
-// Deprecated: Use NewMyUnion().GetMyDataItem() instead.
-func (x *MyUnion) DefaultGetMyDataItem() *MyDataItem {
-    if !x.IsSetMyDataItem() {
-        return NewMyDataItem()
-    }
-    return x.MyDataItem
-}
 
 func (x *MyUnion) countSetFields() int {
     count := int(0)
@@ -1691,21 +1670,7 @@ func (x *MyException) readField4(p thrift.Decoder) error {  // MyUnion
     return nil
 }
 
-// Deprecated: Use NewMyException().GetMyStruct() instead.
-func (x *MyException) DefaultGetMyStruct() *MyStruct {
-    if !x.IsSetMyStruct() {
-        return NewMyStruct()
-    }
-    return x.MyStruct
-}
 
-// Deprecated: Use NewMyException().GetMyUnion() instead.
-func (x *MyException) DefaultGetMyUnion() *MyUnion {
-    if !x.IsSetMyUnion() {
-        return NewMyUnion()
-    }
-    return x.MyUnion
-}
 
 
 
@@ -1994,21 +1959,7 @@ func (x *MyExceptionWithMessage) readField4(p thrift.Decoder) error {  // MyUnio
     return nil
 }
 
-// Deprecated: Use NewMyExceptionWithMessage().GetMyStruct() instead.
-func (x *MyExceptionWithMessage) DefaultGetMyStruct() *MyStruct {
-    if !x.IsSetMyStruct() {
-        return NewMyStruct()
-    }
-    return x.MyStruct
-}
 
-// Deprecated: Use NewMyExceptionWithMessage().GetMyUnion() instead.
-func (x *MyExceptionWithMessage) DefaultGetMyUnion() *MyUnion {
-    if !x.IsSetMyUnion() {
-        return NewMyUnion()
-    }
-    return x.MyUnion
-}
 
 
 
@@ -2709,13 +2660,6 @@ func (x *respFB303ServiceSimpleRPC) readField0(p thrift.Decoder) error {  // Suc
     return nil
 }
 
-// Deprecated: Use newRespFB303ServiceSimpleRPC().GetSuccess() instead.
-func (x *respFB303ServiceSimpleRPC) DefaultGetSuccess() *ReservedKeyword {
-    if !x.IsSetSuccess() {
-        return NewReservedKeyword()
-    }
-    return x.Success
-}
 
 
 

third-party/thrift/src/thrift/compiler/test/fixtures/complex-union/out/go/gen-go/module/types.go

@@ -1398,21 +1398,7 @@ func (x *ValUnion) readField2(p thrift.Decoder) error {  // V2
     return nil
 }
 
-// Deprecated: Use NewValUnion().GetV1() instead.
-func (x *ValUnion) DefaultGetV1() *Val {
-    if !x.IsSetV1() {
-        return NewVal()
-    }
-    return x.V1
-}
 
-// Deprecated: Use NewValUnion().GetV2() instead.
-func (x *ValUnion) DefaultGetV2() *Val {
-    if !x.IsSetV2() {
-        return NewVal()
-    }
-    return x.V2
-}
 
 func (x *ValUnion) countSetFields() int {
     count := int(0)
@@ -1892,13 +1878,6 @@ func (x *NonCopyableUnion) readField1(p thrift.Decoder) error {  // S
     return nil
 }
 
-// Deprecated: Use NewNonCopyableUnion().GetS() instead.
-func (x *NonCopyableUnion) DefaultGetS() *NonCopyableStruct {
-    if !x.IsSetS() {
-        return NewNonCopyableStruct()
-    }
-    return x.S
-}
 
 func (x *NonCopyableUnion) countSetFields() int {
     count := int(0)