Update systemlib generation to support precompiled systemlibs#9619
Open
mszabo-wikia wants to merge 1 commit intofacebook:masterfrom
Open
Update systemlib generation to support precompiled systemlibs#9619mszabo-wikia wants to merge 1 commit intofacebook:masterfrom
mszabo-wikia wants to merge 1 commit intofacebook:masterfrom
Conversation
Contributor
|
@facebook-github-bot has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. (Because this pull request was imported automatically, there will not be any future comments.) |
mszabo-wikia
force-pushed
the
precompile-systemlibs
branch
from
27f4c80 to
63ea57d
Compare
Contributor
|
@mszabo-wikia has updated the pull request. You must reimport the pull request before landing. |
Since D46606416, we include precompiled unitemitters rather than raw Hack source files for systemlibs into the HHVM binary. This requires corresponding updates to the OSS build system. * Update embed_all_systemlibs() and embed_systemlibs_byname() to invoke HHVM to compile systemlibs, and update section name generation to match. * Update systemlib generation to correctly look for systemlib sources under hphp/runtime/ext/core instead of hphp/system after they were moved in D46164829. * Make tc-print depend on HHVM, since the hhvm binary is required to compile and embed systemlibs into tc-print. * Fix apparently erroneous contains() check (added in D65835121) in compiler-systemlib.cpp that checks for `file` but then tries to access `"ext_" + file`. This is erroring in OSS, since all extension systemlibs are named ext_something.php, not something.php.
mszabo-wikia
force-pushed
the
precompile-systemlibs
branch
from
63ea57d to
4340157
Compare
Contributor
|
@mszabo-wikia has updated the pull request. You must reimport the pull request before landing. |
|
@facebook-github-bot has imported this pull request. If you are a Meta employee, you can view this in D76160386. (Because this pull request was imported automatically, there will not be any future comments.) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Since D46606416, we include precompiled unitemitters rather than raw Hack source files for systemlibs into the HHVM binary. This requires corresponding updates to the OSS build system.
filebut then tries to access"ext_" + file. This is erroring in OSS, since all extension systemlibs are named ext_something.php, not something.php.