Open
Conversation
Contributor
|
@facebook-github-bot has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. (Because this pull request was imported automatically, there will not be any future comments.) |
mszabo-wikia
force-pushed
the
fix-trivial-oss-test-failures
branch
from
97f0f9f to
a15aff6
Compare
Contributor
|
@mszabo-wikia has updated the pull request. You must reimport the pull request before landing. |
Address some straightforward test failures in HHVM OSS: * Gate tests for internal Meta extensions behind appropriate runif checks. * Set -vPHP7.EngineExceptions=false for some tests that assume this, as this knob defaults to false in internal builds but to true in OSS. * Skip tests that exercise fb_(un)serialize() outside internal builds, since FBSerialize was removed from HHVM OSS in D46525242. * Skip version.php since the OSS version format may differ.
mszabo-wikia
force-pushed
the
fix-trivial-oss-test-failures
branch
from
a15aff6 to
a14cf10
Compare
Contributor
|
@mszabo-wikia has updated the pull request. You must reimport the pull request before landing. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Address some straightforward test failures in HHVM OSS:
-vPHP7.EngineExceptions=falsefor some tests that assume this, as this knob defaults to false in internal builds but to true in OSS.