[lexical-link][Bug Fix] avoid auto-linking urls in code snippets #8036
+34
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xnt
requested review from
acywatson,
etrepum,
fantactuka,
ivailop7,
potatowagon,
takuyakanbr and
zurfyx
as code owners
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
meta-cla
bot
added
the
CLA Signed
etrepum
reviewed
Dec 19, 2025
Collaborator
etrepum
left a comment
etrepum
left a comment
There was a problem hiding this comment.
This introduces a dependency on @lexical/code from @lexical/link which breaks the build and is not desired. One way or another this issue should be addressed in a way that doesn't introduce this kind of dependency (note also that checking getType() is also not an acceptable solution because the type of a CodeNode can be any string if it's subclassed).
A cleaner possibility might be to add configuration to AutoLinkConfig to allow you to specify some predicates that control which nodes shouldn't be considered. The extensions could have a peer dependency to set this up automatically for CodeNode.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The AutoLinkPlugin (registerAutoLink underneath) does not take code blocks into account, and inserts AutoLinks in code blocks, even though this is not usually desired. This only happens if a highlighter plugin is not used. Can be easily reproduced in the Lexical playground.
This fix validates that the current block is not a code block before trying to insert auto-links. Also, adds a test with that check.
Closes #8028
Test plan
Before
After