Let --cmake-target be repeatable

Summary: Let `--cmake-target` be repeatable so that we can specify multiple targets in one `getdeps.py` command.

Reviewed By: yfeldblum

Differential Revision: D91143384

fbshipit-source-id: f0573bcd2903627389f8aa373e2f96edffa42446

Author: mcfi

build/fbcode_builder/getdeps.py

@@ -687,6 +687,7 @@ def run_project_cmd(self, args, loader, manifest):
                 )
 
                 extra_b2_args = args.extra_b2_args or []
+                cmake_targets = args.cmake_target or ["install"]
 
                 if sources_changed or reconfigure or not os.path.exists(built_marker):
                     if os.path.exists(built_marker):
@@ -715,7 +716,7 @@ def run_project_cmd(self, args, loader, manifest):
                         dep_manifests,
                         final_install_prefix=loader.get_project_install_prefix(m),
                         extra_cmake_defines=extra_cmake_defines,
-                        cmake_target=args.cmake_target if m == manifest else "install",
+                        cmake_targets=(cmake_targets if m == manifest else ["install"]),
                         extra_b2_args=extra_b2_args,
                     )
                     builder.build(reconfigure=reconfigure)
@@ -726,7 +727,7 @@ def run_project_cmd(self, args, loader, manifest):
                     # for the project to run with different cmake_targets to trigger
                     # cmake
                     has_built_marker = False
-                    if not (m == manifest and args.cmake_target != "install"):
+                    if not (m == manifest and "install" not in cmake_targets):
                         with open(built_marker, "w") as f:
                             f.write(project_hash)
                             has_built_marker = True
@@ -860,8 +861,9 @@ def setup_project_cmd_parser(self, parser):
         )
         parser.add_argument(
             "--cmake-target",
-            help=("Target for cmake build."),
-            default="install",
+            help=("Repeatable argument that specifies targets for cmake build."),
+            default=[],
+            action="append",
         )
         parser.add_argument(
             "--extra-b2-args",

build/fbcode_builder/getdeps/builder.py

@@ -685,7 +685,7 @@ def __init__(
         defines,
         final_install_prefix=None,
         extra_cmake_defines=None,
-        cmake_target="install",
+        cmake_targets=None,
     ) -> None:
         super(CMakeBuilder, self).__init__(
             loader,
@@ -701,7 +701,7 @@ def __init__(
         self.defines = defines or {}
         if extra_cmake_defines:
             self.defines.update(extra_cmake_defines)
-        self.cmake_target = cmake_target
+        self.cmake_targets = cmake_targets or ["install"]
 
         if build_opts.is_windows():
             try:
@@ -897,12 +897,9 @@ def _build(self, reconfigure: bool) -> None:
             self._check_cmd([cmake, self.src_dir] + define_args, env=env)
 
         self._check_cmd(
-            [
-                cmake,
-                "--build",
-                self.build_dir,
-                "--target",
-                self.cmake_target,
+            [cmake, "--build", self.build_dir, "--target"]
+            + self.cmake_targets
+            + [
                 "--config",
                 self.build_opts.build_type,
                 "-j",

build/fbcode_builder/getdeps/manifest.py

@@ -524,7 +524,7 @@ def create_builder(  # noqa:C901
         dep_manifests,
         final_install_prefix=None,
         extra_cmake_defines=None,
-        cmake_target=None,
+        cmake_targets=None,
         extra_b2_args=None,
     ):
         builder = self.get_builder_name(ctx)
@@ -621,7 +621,7 @@ def create_builder(  # noqa:C901
                 defines,
                 final_install_prefix,
                 extra_cmake_defines,
-                cmake_target,
+                cmake_targets,
             )
 
         if builder == "python-wheel":