[easy] Fix runtime checkable protocol unsafe overlap with inheritance test case #1695
+26
−21
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… test case Summary: This diff does two minor fixes. (1) The test `test_runtime_checkable_unsafe_overlap_with_inheritance` was not a bug. `@runtime_checkable` requires a direct inheritance of `Protocol`, so the error message is valid. Otherwise, a runtime error would be thrown. This diff adds the direct inheritance and the expected error for unsafe overlap is emitted. (2) When there are multiple unsafe overlaps exists for a runtime checkable protocol, multiple errors were emitted. This treatment was suboptimal, so this diff groups the errors into a single error, and explains all the overlapping fields in a multi-line error message. Test Plan: `test.py`
stroxler
reviewed
Nov 28, 2025
Contributor
stroxler
left a comment
stroxler
left a comment
There was a problem hiding this comment.
LGTM, I'll try to get a second review
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This diff does two minor fixes.
(1)
The test
test_runtime_checkable_unsafe_overlap_with_inheritancewas not a bug.@runtime_checkablerequires a direct inheritance ofProtocol, so the error message is valid.Otherwise, a runtime error would be thrown.
This diff adds the direct inheritance and the expected error for unsafe overlap is emitted.
(2)
When there are multiple unsafe overlaps exists for a runtime checkable protocol, multiple errors were emitted.
This treatment was suboptimal, so this diff groups the errors into a single error, and explains all the overlapping fields in a multi-line error message.
Test Plan
test.py