Add support for the TSP typeServer/getPythonSearchPaths message #2649
Open
rchiodo wants to merge 7 commits intofacebook:mainfrom
Open
Add support for the TSP typeServer/getPythonSearchPaths message #2649rchiodo wants to merge 7 commits intofacebook:mainfrom
rchiodo wants to merge 7 commits intofacebook:mainfrom
Conversation
|
According to mypy_primer, this change doesn't affect type check results on a corpus of open source code. ✅ |
Contributor
|
test failures seem unrelated. importing + rerunning CI |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds support for the next TSP message = typeServer/getPythonSearchPaths. This message is used to convey basically PYTHONPATH to the other side. In our case, Pylance uses this to find implementations for stubs.
Test Plan
Added a number of unit tests and ran tests.py. Also refactored some of the existing TSP test code to use common functions.
/cc @kinto0