Skip to content

Add documentation hover for assignments with docstring#2670

Open
oyarsa wants to merge 1 commit intofacebook:mainfrom
oyarsa:main
Open

Add documentation hover for assignments with docstring#2670
oyarsa wants to merge 1 commit intofacebook:mainfrom
oyarsa:main

Conversation

@oyarsa
Copy link

@oyarsa oyarsa commented Mar 5, 2026

Summary

This PR adds attribute docstrings (PEP 257) to hover from assignments, including type aliases.

Fixes #2620

Test Plan

  • test.py passes. It generated no changes to be commited. There are some compilation warnings, but I believe they are unrelated to the code in this PR.
  • Tested as the LSP on neovim 0.11.6 with default lspconfig settings. I copied target/release/pyrefly to a directory in PATH.

@meta-cla
Copy link

meta-cla bot commented Mar 5, 2026

Hi @oyarsa!

Thank you for your pull request and welcome to our community.

Action Required

In order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you.

Process

In order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with CLA signed. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.

If you have received this in error or have any questions, please contact us at cla@meta.com. Thanks!

@meta-cla meta-cla bot added the cla signed label Mar 5, 2026
@meta-cla
Copy link

meta-cla bot commented Mar 5, 2026

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Meta Open Source project. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Docstrings on variables

1 participant