Fix collections.namedtuple not recognized when collections.abc is imported#2671
Open
yangdanny97 wants to merge 1 commit intofacebook:mainfrom
Open
Fix collections.namedtuple not recognized when collections.abc is imported#2671yangdanny97 wants to merge 1 commit intofacebook:mainfrom
yangdanny97 wants to merge 1 commit intofacebook:mainfrom
Conversation
…orted
Summary:
When `import collections.abc` follows `import collections`, the flow style for the name `collections` was overwritten with `MergeableImport("collections.abc")`. This caused `as_special_export` to check `is_special_export("collections.abc", "namedtuple")`, which failed because `CollectionsNamedTuple.defined_in()` only matches `"collections"`.
Fix: for `MergeableImport`, use the bound name (which is always the first component of the dotted import path) as the module name for special export checking, instead of the stored full dotted path.
Fixes facebook#2622
Differential Revision: D95422174
|
@yangdanny97 has exported this pull request. If you are a Meta employee, you can view the originating Diff in D95422174. |
|
According to mypy_primer, this change doesn't affect type check results on a corpus of open source code. ✅ |
kinto0
approved these changes
Mar 5, 2026
Contributor
kinto0
left a comment
kinto0
left a comment
There was a problem hiding this comment.
Review automatically exported from Phabricator review in Meta.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
When
import collections.abcfollowsimport collections, the flow style for the namecollectionswas overwritten withMergeableImport("collections.abc"). This causedas_special_exportto checkis_special_export("collections.abc", "namedtuple"), which failed becauseCollectionsNamedTuple.defined_in()only matches"collections".Fix: for
MergeableImport, use the bound name (which is always the first component of the dotted import path) as the module name for special export checking, instead of the stored full dotted path.Fixes #2622
Differential Revision: D95422174