Skip to content

track stack trace symbolication failures #183

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
vzaidman merged 1 commit into from
Jun 26, 2025
Merged

track stack trace symbolication failures #183

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
22 changes: 21 additions & 1 deletion front_end/core/host/RNPerfMetrics.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -259,6 +259,17 @@ class RNPerfMetrics {
});
}

stackTraceSymbolicationFailed(stackTrace: string, line: string, reason: string): void {
this.sendEvent({
eventName: 'StackTraceSymbolicationFailed',
params: {
stackTrace,
line,
reason,
},
});
}

panelShown(_panelName: string, _isLaunching?: boolean): void {
// no-op
// We only care about the "main" and "drawer" panels for now via panelShownInLocation(…)
Expand Down Expand Up @@ -423,10 +434,19 @@ export type PanelClosedEvent = Readonly<{
}>,
}>;

export type StackTraceSymbolicationFailed = Readonly<{
eventName: 'StackTraceSymbolicationFailed',
params: Readonly<{
stackTrace: string,
line: string,
reason: string,
}>,
}>;

export type ReactNativeChromeDevToolsEvent =
EntrypointLoadingStartedEvent|EntrypointLoadingFinishedEvent|DebuggerReadyEvent|BrowserVisibilityChangeEvent|
BrowserErrorEvent|RemoteDebuggingTerminatedEvent|DeveloperResourceLoadingStartedEvent|
DeveloperResourceLoadingFinishedEvent|FuseboxSetClientMetadataStartedEvent|FuseboxSetClientMetadataFinishedEvent|
MemoryPanelActionStartedEvent|MemoryPanelActionFinishedEvent|PanelShownEvent|PanelClosedEvent;
MemoryPanelActionStartedEvent|MemoryPanelActionFinishedEvent|PanelShownEvent|PanelClosedEvent|StackTraceSymbolicationFailed;

export type DecoratedReactNativeChromeDevToolsEvent = CommonEventFields&ReactNativeChromeDevToolsEvent;
5 changes: 5 additions & 0 deletions front_end/panels/console/ErrorStackParser.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,7 @@
// found in the LICENSE file.

import * as Common from '../../core/common/common.js';
import * as Host from '../../core/host/host.js';
import type * as Platform from '../../core/platform/platform.js';
import type * as SDK from '../../core/sdk/sdk.js';
import type * as Protocol from '../../generated/protocol.js';
Expand Down Expand Up @@ -43,6 +44,7 @@ export function parseSourcePositionsFromErrorStack(
const match = /^\s*at\s(async\s)?/.exec(line);
if (!match) {
if (linkInfos.length && linkInfos[linkInfos.length - 1].isCallFrame) {
Host.rnPerfMetrics.stackTraceSymbolicationFailed(stack, line, '"at (url)" not found');
return null;
}
linkInfos.push({line});
Expand All @@ -59,6 +61,7 @@ export function parseSourcePositionsFromErrorStack(
do {
left = line.indexOf(' (', left);
if (left < 0) {
Host.rnPerfMetrics.stackTraceSymbolicationFailed(stack, line, 'left "(" not found');
return null;
}
left += 2;
Expand All @@ -68,6 +71,7 @@ export function parseSourcePositionsFromErrorStack(
left += 8;
right = line.lastIndexOf(', ', right) - 1;
if (right < 0) {
Host.rnPerfMetrics.stackTraceSymbolicationFailed(stack, line, 'right "(" not found');
return null;
}
} while (true);
Expand All @@ -89,6 +93,7 @@ export function parseSourcePositionsFromErrorStack(
url = parseOrScriptMatch(debuggerModel, Common.ParsedURL.ParsedURL.completeURL(baseURL, splitResult.url));
}
if (!url) {
Host.rnPerfMetrics.stackTraceSymbolicationFailed(stack, line, 'url parsing failed');
return null;
}

Expand Down
Loading