Skip to content

Add new line between errors #198

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
vzaidman merged 1 commit into from
Aug 6, 2025
Merged

Add new line between errors #198

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions front_end/panels/console/ConsoleViewMessage.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -989,7 +989,7 @@ export class ConsoleViewMessage implements ConsoleViewportElement {
// The Exceptiondetails include script IDs for stack frames, which allows more accurate
// linking.
const formatErrorStack =
async(errorObj: SDK.RemoteObject.RemoteObject, includeCausedByPrefix = false): Promise<void> => {
async(errorObj: SDK.RemoteObject.RemoteObject, includeCausedByPrefix: boolean): Promise<void> => {
const error = SDK.RemoteObject.RemoteError.objectAsError(errorObj);
const [details, cause] = await Promise.all([error.exceptionDetails(), error.cause()]);
let errorElement = this.tryFormatAsError(error.errorStack, details);
Expand All @@ -1015,7 +1015,7 @@ export class ConsoleViewMessage implements ConsoleViewportElement {
}
};

this.#formatErrorStackPromiseForTest = formatErrorStack(output);
this.#formatErrorStackPromiseForTest = formatErrorStack(output, /* includeCausedByPrefix */ false);

return result;
}
Expand Down
17 changes: 11 additions & 6 deletions front_end/panels/console/consoleView.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -393,28 +393,33 @@
word-break: break-all;
}

.formatted-stack-frame:has(.ignore-list-link) {
display: var(--display-ignored-formatted-stack-frame);
opacity: 60%;
.formatted-stack-frame {
display: var(--display-formatted-stack-frame-default);

/* Subsequent builtin stack frames are also treated as ignored */
& + .formatted-builtin-stack-frame {
&:has(.ignore-list-link) {
display: var(--display-ignored-formatted-stack-frame);
opacity: 60%;

/* Subsequent builtin stack frames are also treated as ignored */
& + .formatted-builtin-stack-frame {
display: var(--display-ignored-formatted-stack-frame);
opacity: 60%;
}
}
}
}

.console-message-stack-trace-wrapper {
--override-display-stack-preview-toggle-link: none;
--display-formatted-stack-frame-default: block;

flex: 1 1 auto;
display: flex;
flex-direction: column;
align-items: stretch;

&:has(div > .stack-preview-container.show-hidden-rows) {
--display-ignored-formatted-stack-frame: inherit;
--display-ignored-formatted-stack-frame: var(--display-formatted-stack-frame-default);
}

&:has(.formatted-stack-frame .ignore-list-link):has(.formatted-stack-frame .devtools-link:not(.ignore-list-link)) {
Expand Down
Loading