Skip to content

feat: add React Native-only event for pre-enabling multiple layers of Tracing #199

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
hoxyq merged 1 commit into from
Aug 5, 2025
Merged

feat: add React Native-only event for pre-enabling multiple layers of Tracing #199

hoxyq merged 1 commit into from
Aug 5, 2025

Conversation

@hoxyq
Copy link

@hoxyq hoxyq commented Aug 5, 2025

Summary

React Native will send ReactNativeApplication.traceRequested event to signal to Frontend that it should prepare for Trace that will be sent over CDP.

Once received, it will update the state on the Frontend and would subscribe to next Tracing.dataCollected and Tracing.tracingComplete events.

Test plan

Just an end-to-end test with pre-defined setup in React Native.

Validated that I can record another trace from the Performance panel after opening stashed one.

  • This change maintains backwards compatibility with previous Local Storage data (if modifying settings, experiments, or other persisted client state).

Upstreaming plan

@hoxyq hoxyq requested review from huntie, rubennorte and sbuggay August 5, 2025 15:20
@meta-cla meta-cla bot added the cla signed label Aug 5, 2025
sbuggay
sbuggay approved these changes Aug 5, 2025
View reviewed changes
@hoxyq hoxyq force-pushed the stashed-traces-support branch from 7abb470 to d05c282 Compare August 5, 2025 15:29
@hoxyq hoxyq force-pushed the stashed-traces-support branch from d05c282 to 529e4e0 Compare August 5, 2025 16:10
@hoxyq hoxyq merged commit 9215667 into main Aug 5, 2025
6 checks passed
@hoxyq hoxyq deleted the stashed-traces-support branch August 5, 2025 17:09
hoxyq added a commit to hoxyq/react-native that referenced this pull request Aug 5, 2025
@hoxyq @facebook-github-bot
Send custom CDP Event to Frontend to prepare for displaying a trace
8742ff3 
Summary:
# Changelog: [Internal]

We need this to notify Frontend, so it updates the local state before receiving `Tracing.dataCollected` events.

Corresponding change in CDT fork - facebook/react-native-devtools-frontend#199.

Differential Revision: D79672598
@hoxyq hoxyq mentioned this pull request Aug 5, 2025
Closed
sbuggay pushed a commit to sbuggay/react-native that referenced this pull request Aug 18, 2025
@facebook-github-bot
Send custom CDP Event to Frontend to prepare for displaying a trace
b593aad 
Summary:
# Changelog: [Internal]

We need this to notify Frontend, so it updates the local state before receiving `Tracing.dataCollected` events.

Corresponding change in CDT fork - facebook/react-native-devtools-frontend#199.

Differential Revision: D79672598
hoxyq added a commit to hoxyq/react-native that referenced this pull request Aug 21, 2025
@hoxyq @facebook-github-bot
Send custom CDP Event to Frontend to prepare for displaying a trace (f…
765839c 
…acebook#53079)

Summary:

# Changelog: [Internal]

We need this to notify Frontend, so it updates the local state before receiving `Tracing.dataCollected` events.

Corresponding change in CDT fork - facebook/react-native-devtools-frontend#199.

Reviewed By: sbuggay

Differential Revision: D79672598
hoxyq added a commit to hoxyq/react-native that referenced this pull request Aug 21, 2025
@hoxyq @facebook-github-bot
Send custom CDP Event to Frontend to prepare for displaying a trace (f…
c320514 
…acebook#53079)

Summary:

# Changelog: [Internal]

We need this to notify Frontend, so it updates the local state before receiving `Tracing.dataCollected` events.

Corresponding change in CDT fork - facebook/react-native-devtools-frontend#199.

Reviewed By: sbuggay

Differential Revision: D79672598
hoxyq added a commit to hoxyq/react-native that referenced this pull request Aug 21, 2025
@hoxyq @facebook-github-bot
Send custom CDP Event to Frontend to prepare for displaying a trace (f…
91a1f39 
…acebook#53079)

Summary:
Pull Request resolved: facebook#53079

# Changelog: [Internal]

We need this to notify Frontend, so it updates the local state before receiving `Tracing.dataCollected` events.

Corresponding change in CDT fork - facebook/react-native-devtools-frontend#199.

Reviewed By: sbuggay

Differential Revision: D79672598
hoxyq added a commit to hoxyq/react-native that referenced this pull request Aug 22, 2025
@hoxyq @facebook-github-bot
Send custom CDP Event to Frontend to prepare for displaying a trace (f…
d7d4b4f 
…acebook#53079)

Summary:

# Changelog: [Internal]

We need this to notify Frontend, so it updates the local state before receiving `Tracing.dataCollected` events.

Corresponding change in CDT fork - facebook/react-native-devtools-frontend#199.

Reviewed By: sbuggay

Differential Revision: D79672598
hoxyq added a commit to hoxyq/react-native that referenced this pull request Aug 22, 2025
@hoxyq @facebook-github-bot
Send custom CDP Event to Frontend to prepare for displaying a trace (f…
117c623 
…acebook#53079)

Summary:

# Changelog: [Internal]

We need this to notify Frontend, so it updates the local state before receiving `Tracing.dataCollected` events.

Corresponding change in CDT fork - facebook/react-native-devtools-frontend#199.

Reviewed By: sbuggay

Differential Revision: D79672598
hoxyq added a commit to hoxyq/react-native that referenced this pull request Aug 22, 2025
@hoxyq @facebook-github-bot
Send custom CDP Event to Frontend to prepare for displaying a trace (f…
335393f 
…acebook#53079)

Summary:
Pull Request resolved: facebook#53079

# Changelog: [Internal]

We need this to notify Frontend, so it updates the local state before receiving `Tracing.dataCollected` events.

Corresponding change in CDT fork - facebook/react-native-devtools-frontend#199.

Reviewed By: sbuggay

Differential Revision: D79672598
hoxyq pushed a commit to hoxyq/react-native that referenced this pull request Aug 22, 2025
@facebook-github-bot
Send custom CDP Event to Frontend to prepare for displaying a trace
a0a9332 
Summary:
# Changelog: [Internal]

We need this to notify Frontend, so it updates the local state before receiving `Tracing.dataCollected` events.

Corresponding change in CDT fork - facebook/react-native-devtools-frontend#199.

Differential Revision: D79672598
facebook-github-bot pushed a commit to facebook/react-native that referenced this pull request Aug 22, 2025
@hoxyq @facebook-github-bot
Send custom CDP Event to Frontend to prepare for displaying a trace (#…
80f340e 
…53079)

Summary:
Pull Request resolved: #53079

# Changelog: [Internal]

We need this to notify Frontend, so it updates the local state before receiving `Tracing.dataCollected` events.

Corresponding change in CDT fork - facebook/react-native-devtools-frontend#199.

Reviewed By: sbuggay

Differential Revision: D79672598

fbshipit-source-id: b2928cb3942e34a1f4723516ecdf5062d4331591
kikoso pushed a commit to kikoso/react-native that referenced this pull request Aug 26, 2025
@hoxyq @kikoso
Send custom CDP Event to Frontend to prepare for displaying a trace (f…
605d0cd 
…acebook#53079)

Summary:
Pull Request resolved: facebook#53079

# Changelog: [Internal]

We need this to notify Frontend, so it updates the local state before receiving `Tracing.dataCollected` events.

Corresponding change in CDT fork - facebook/react-native-devtools-frontend#199.

Reviewed By: sbuggay

Differential Revision: D79672598

fbshipit-source-id: b2928cb3942e34a1f4723516ecdf5062d4331591
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@sbuggay sbuggay sbuggay approved these changes

@rubennorte rubennorte Awaiting requested review from rubennorte

@huntie huntie Awaiting requested review from huntie

Assignees

No one assigned

Labels

cla signed

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@hoxyq @sbuggay