Skip to content

Gate performance screenshots toggle to Android only #227

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
sbuggay merged 4 commits into from
Dec 4, 2025
Merged

Gate performance screenshots toggle to Android only #227

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
61ca433
Gate screenshots toggle to android only
sbuggay Dec 4, 2025
198245e
Cleanup
sbuggay Dec 4, 2025
d94f5cb
Merge branch 'main' into users/devanb/screenshots-android-gate
sbuggay Dec 4, 2025
6448ad1
Address race condition
sbuggay Dec 4, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 19 additions & 0 deletions front_end/panels/timeline/TimelinePanel.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -712,6 +712,14 @@ export class TimelinePanel extends UI.Panel.Panel implements Client, TimelineMod
SDK.ReactNativeApplicationModel.ReactNativeApplicationModel,
{
modelAdded: (model: SDK.ReactNativeApplicationModel.ReactNativeApplicationModel) => {
model.addEventListener(
SDK.ReactNativeApplicationModel.Events.METADATA_UPDATED,
(event: Common.EventTarget.EventTargetEvent<Protocol.ReactNativeApplication.MetadataUpdatedEvent>) => {
if (event.data.platform === 'android') {
this.showScreenshotsToolbarCheckbox?.setVisible(true);
}
}
);
model.addEventListener(
SDK.ReactNativeApplicationModel.Events.TRACE_REQUESTED, () => this.rnPrepareForTraceCapturedInBackground());
},
Expand Down Expand Up @@ -1192,6 +1200,17 @@ export class TimelinePanel extends UI.Panel.Panel implements Client, TimelineMod
if (!isNode && (Root.Runtime.experiments.isEnabled(Root.Runtime.RNExperimentName.ENABLE_TIMELINE_FRAMES) || !isReactNative)) {
this.showScreenshotsToolbarCheckbox =
this.createSettingCheckbox(this.showScreenshotsSetting, i18nString(UIStrings.captureScreenshots));

let showScreenshotsToggle = false;

const reactNativeApplicationModel = SDK.TargetManager.TargetManager.instance().primaryPageTarget()?.model(SDK.ReactNativeApplicationModel.ReactNativeApplicationModel);
if (reactNativeApplicationModel !== null && reactNativeApplicationModel !== undefined) {
showScreenshotsToggle = reactNativeApplicationModel.metadataCached?.platform === 'android';
}

// Only show this toggle if we are on android, to address a possible race condition with the platform metadata,
// this is also checked again on SDK.ReactNativeApplicationModel.Events.METADATA_UPDATED
this.showScreenshotsToolbarCheckbox.setVisible(showScreenshotsToggle);
this.panelToolbar.appendToolbarItem(this.showScreenshotsToolbarCheckbox);
}

Expand Down
Loading