fix: check if infobar custom element is already registered #232
+3
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
huntie
reviewed
Jan 8, 2026
| } | ||
|
|
||
| customElements.define('devtools-network-event-coverage-infobar', NetworkEventCoverageInfobar); | ||
| if (!customElements.get('devtools-network-event-coverage-infobar')) { |
Member
There was a problem hiding this comment.
Thanks Ruslan.
There isn't a single other customElements.get() reference in the codebase, so I'm curious to find out what I was missing from this CDT component pattern. Following up 👍🏻
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Temporary mitigation to fix JS error on client side that affects Network and Performance panels. Might not be the desired fix.
Test plan
With these changes, I can see Network and Performance panels rendered.
Upstreaming plan
devtools-frontendrepo following the contribution guide for Meta employees OR contribution guide.