Replace ThemeImage with ThemedImage and update image sources to use useBaseUrl #4512
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
❌ Deploy Preview for react-native failed.
|
✅ Deploy Preview for react-native ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
|
Nice catch @clicktodev, thanks for working on those changes! 🙏 Sorry to see that this did not get over the finish line. Due to inactivity, and draft status of that contribution we decided to fix and ship this separately, since the issue has been brought up again in recent weeks. Closing in favour of: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Transition from ThemeImage to ThemedImage for improved image handling and update image sources to utilize useBaseUrl for better path management.
edit: looks like the components need to be moved out of the pages folder so they don't get SSGed without the layout wrapper to avoid context error