-
Notifications
You must be signed in to change notification settings - Fork 5.3k
docs: iOS Hermes export USE_HERMES=true
warning added.
#4807
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
✅ Deploy Preview for react-native ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
</TabItem> | ||
</Tabs> | ||
|
||
Add `export USE_HERMES=true` to `/ios/.xcode.env` for [Hermes bytecoded](https://github.com/facebook/react-native/blob/4d2e38edd97a87e93cb95a8a0021abf73765cf28/packages/react-native/scripts/react-native-xcode.sh#L166C8-L166C18) bundle on iOS. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why are you adding this?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Because on iOS side without this variable release builds is not rendered by hermes.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nope you should not be needing to add export USE_HERMES=true to your .xcode.env
file. I think there is something going on in your setup.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think there is fuzzy situation, when I add hermes_enable value to Podfile I expected to release build would have been byte coded version as same as android without installing pods with USE_HERMES=1
which is not seems on documantation also.
I'm not quite sure but there is fuzy situation which is not explained on this type. We need to add this USE_HERMES=1 bundle exec pod install
or mine idk
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hermes is the default engine. If you don't specify anything, that would be used by default.
I think that your setup has some issue and that's not the base situation for all our users, so we should not add this into the documentation
</TabItem> | ||
</Tabs> | ||
|
||
Add `export USE_HERMES=true` to `/ios/.xcode.env` for [Hermes bytecoded](https://github.com/facebook/react-native/blob/4d2e38edd97a87e93cb95a8a0021abf73765cf28/packages/react-native/scripts/react-native-xcode.sh#L166C8-L166C18) bundle on iOS. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hermes is the default engine. If you don't specify anything, that would be used by default.
I think that your setup has some issue and that's not the base situation for all our users, so we should not add this into the documentation
Just to clarify, this flag is only used during the pod installation process. For example, if I change it from true to false, the change won’t take effect until I run pod install again isn't? and this situation is not explicitly informed, I think this case should been added docs, I could add related information in docs if you aggree with me. |
@zaferatli correct. That is an env var for Cocoapods only, which controls whether Hermes should be installed. |
on iOS side with this value hermes isn't working.