docs: Clearify swapLeftAndRightInRTL functionality #4826
Conversation
|
Hi @HarwinBorger! Thank you for your pull request and welcome to our community. Action RequiredIn order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you. ProcessIn order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA. Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with If you have received this in error or have any questions, please contact us at [email protected]. Thanks! |
✅ Deploy Preview for react-native ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
|
CLA is signed, github actions need a re-run |
HarwinBorger
changed the title
|
Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Meta Open Source project. Thanks! |
| Swap left and right style properties in RTL mode. When enabled, left becomes right and right becomes left in RTL layouts. Does not affect the value of `isRTL`. | ||
| Swap left and right style properties in RTL mode. When enabled, left becomes right and right becomes left in RTL layouts. Does not affect the value of `isRTL`. |
There was a problem hiding this comment.
this change seems to just be an unnecessary space at the end?
There was a problem hiding this comment.
Thank you, you are correct, I will remove it.
Current docs don’t clearly explain how swapLeftAndRightInRTL interacts with:
• marginLeft / marginRight
• paddingLeft / paddingRight
• Absolute positioning (left / right)
This leads to confusion, because developers may expect left / right to flip automatically, which it does not.
Also it's not clear what the default state of swapLeftAndRightInRTL is. This PR gives explaination on this behaviour.