Skip to content

Commit 046ff8e

Browse files
cortinicofacebook-github-bot
authored andcommitted
Make OnBatchCompleteListener interface internal (#53409)
Summary: Pull Request resolved: #53409 This interface is public and is part of Legacy Architecture. Having this interface as `public` was a mistake, as users can't really do much with it. There is only one old library that is going to be affected by this change: https://github.com/spoke-ph/react-native-threads The library appears unmaintained since RN 0.69 + no NewArch support so I won't consider this a breaking change given this will land in 0.82. I'm making it internal so we can remove it more easily later. Changelog: [Android] [Changed] - Make OnBatchCompleteListener interface internal Differential Revision: D80715625 fbshipit-source-id: 94fe80eeba95222deab7ca89c5fcafca8fcee0b7
1 parent fb114da commit 046ff8e

File tree

2 files changed

+2
-6
lines changed

2 files changed

+2
-6
lines changed

packages/react-native/ReactAndroid/api/ReactAndroid.api

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1018,10 +1018,6 @@ public abstract interface class com/facebook/react/bridge/NotThreadSafeBridgeIdl
10181018
public abstract fun onTransitionToBridgeIdle ()V
10191019
}
10201020

1021-
public abstract interface class com/facebook/react/bridge/OnBatchCompleteListener {
1022-
public abstract fun onBatchComplete ()V
1023-
}
1024-
10251021
public abstract interface class com/facebook/react/bridge/PerformanceCounter {
10261022
public abstract fun getPerformanceCounters ()Ljava/util/Map;
10271023
public abstract fun profileNextBatch ()V

packages/react-native/ReactAndroid/src/main/java/com/facebook/react/bridge/OnBatchCompleteListener.kt

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -16,6 +16,6 @@ import com.facebook.react.common.annotations.internal.LegacyArchitectureLogLevel
1616
message = "This class is part of Legacy Architecture and will be removed in a future release",
1717
level = DeprecationLevel.WARNING,
1818
)
19-
public fun interface OnBatchCompleteListener {
20-
public fun onBatchComplete()
19+
internal fun interface OnBatchCompleteListener {
20+
fun onBatchComplete()
2121
}

0 commit comments

Comments
 (0)