Skip to content

Commit 064fd59

Browse files
generatedunixname89002005287564meta-codesync[bot]
authored andcommitted
Fix CQS signal readability-redundant-smartptr-get in xplat/js/react-native-github/packages (#54065)
Summary: Pull Request resolved: #54065 Reviewed By: javache Differential Revision: D83817146 fbshipit-source-id: 36bafe7d363d7978e2d74a98aee444af9f538de4
1 parent 3f7f9d8 commit 064fd59

File tree

3 files changed

+6
-6
lines changed

3 files changed

+6
-6
lines changed

packages/react-native/React/Fabric/Mounting/RCTMountingManager.mm

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -299,7 +299,7 @@ - (void)synchronouslyUpdateViewOnUIThread:(ReactTag)reactTag
299299
SurfaceId surfaceId = RCTSurfaceIdForView(componentView);
300300
Props::Shared oldProps = [componentView props];
301301
Props::Shared newProps = componentDescriptor.cloneProps(
302-
PropsParserContext{surfaceId, *_contextContainer.get()}, oldProps, RawProps(std::move(props)));
302+
PropsParserContext{surfaceId, *_contextContainer}, oldProps, RawProps(std::move(props)));
303303

304304
NSSet<NSString *> *propKeys = componentView.propKeysManagedByAnimated_DO_NOT_USE_THIS_IS_BROKEN ?: [NSSet new];
305305
propKeys = [propKeys setByAddingObjectsFromArray:propsKeysToBeUpdated];

packages/react-native/ReactCommon/react/renderer/scheduler/SurfaceHandler.cpp

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -225,7 +225,7 @@ Size SurfaceHandler::measure(
225225
link_.shadowTree->getCurrentRevision().rootShadowNode;
226226

227227
PropsParserContext propsParserContext{
228-
parameters_.surfaceId, *parameters_.contextContainer.get()};
228+
parameters_.surfaceId, *parameters_.contextContainer};
229229

230230
auto rootShadowNode = currentRootShadowNode->clone(
231231
propsParserContext, layoutConstraints, layoutContext);
@@ -329,7 +329,7 @@ void SurfaceHandler::constraintLayout(
329329
}
330330

331331
PropsParserContext propsParserContext{
332-
parameters_.surfaceId, *parameters_.contextContainer.get()};
332+
parameters_.surfaceId, *parameters_.contextContainer};
333333

334334
react_native_assert(
335335
link_.shadowTree && "`link_.shadowTree` must not be null.");

packages/react-native/ReactCommon/react/renderer/uimanager/UIManager.cpp

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -70,7 +70,7 @@ std::shared_ptr<ShadowNode> UIManager::createNode(
7070
auto fallbackDescriptor =
7171
componentDescriptorRegistry_->getFallbackComponentDescriptor();
7272

73-
PropsParserContext propsParserContext{surfaceId, *contextContainer_.get()};
73+
PropsParserContext propsParserContext{surfaceId, *contextContainer_};
7474

7575
auto family = componentDescriptor.createFamily(
7676
{.tag = tag,
@@ -113,7 +113,7 @@ std::shared_ptr<ShadowNode> UIManager::cloneNode(
113113
"UIManager::cloneNode", "componentName", shadowNode.getComponentName());
114114

115115
PropsParserContext propsParserContext{
116-
shadowNode.getFamily().getSurfaceId(), *contextContainer_.get()};
116+
shadowNode.getFamily().getSurfaceId(), *contextContainer_};
117117

118118
auto& componentDescriptor = shadowNode.getComponentDescriptor();
119119
auto& family = shadowNode.getFamily();
@@ -457,7 +457,7 @@ void UIManager::setNativeProps_DEPRECATED(
457457
componentDescriptorRegistry_->at(
458458
shadowNode->getComponentHandle());
459459
PropsParserContext propsParserContext{
460-
family.getSurfaceId(), *contextContainer_.get()};
460+
family.getSurfaceId(), *contextContainer_};
461461
auto props = componentDescriptor.cloneProps(
462462
propsParserContext,
463463
getShadowNodeInSubtree(*shadowNode, ancestorShadowNode)

0 commit comments

Comments
 (0)