Skip to content

Commit c360251

Browse files
realsoelynnfacebook-github-bot
authored andcommitted
Back out "Adding shouldForwardToReactInstance check in ReactDelegate for Bridgeless" (#52303)
Summary: Pull Request resolved: #52303 Investigating javascript crash regression between Store APK v269 and v270 T228736366 with mid https://www.internalfb.com/logview/system_vros_javascripterrors/4a0131b8b79e3994b639c7ca212db717?ds=%7B%22start%22%3A%221750796919%22%2C%22constraints%22%3A[]%2C%22end%22%3A%22now%22%7D&ds_nux_type=task We suspect that this diff stack may be causing the issue could be caused by this Kotlin migration diff stack D76908041 Changelog: [Internal] Reverting Kotlin migration for ReactDelegate Reviewed By: mullender Differential Revision: D77388413 fbshipit-source-id: b144ca6db6f75614c7988e474ef89f19714a4a09
1 parent 793023a commit c360251

File tree

1 file changed

+1
-2
lines changed
  • packages/react-native/ReactAndroid/src/main/java/com/facebook/react

1 file changed

+1
-2
lines changed

packages/react-native/ReactAndroid/src/main/java/com/facebook/react/ReactDelegate.kt

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -195,8 +195,7 @@ public open class ReactDelegate {
195195
shouldForwardToReactInstance: Boolean
196196
) {
197197
if (ReactNativeNewArchitectureFeatureFlags.enableBridgelessArchitecture() &&
198-
reactHost != null &&
199-
shouldForwardToReactInstance) {
198+
reactHost != null) {
200199
reactHost?.onActivityResult(activity, requestCode, resultCode, data)
201200
} else {
202201
if (reactNativeHost?.hasInstance() == true && shouldForwardToReactInstance) {

0 commit comments

Comments
 (0)