Configure @react-native-community/eslint-config as a yarn workspace

[yungsters]

Summary

Changes the React Native base ESLint configuration to consume @react-native-community/eslint-config as a yarn workspace, so that any dependencies of @react-native-community/eslint-config can also be resolved from the root directory of react-native.

Previously, ~/.eslintrc.js extended @react-native-community/eslint-config using a relative file path. This is problematic because if any dependencies (notably, optional peer dependencies such as some of the TypeScript dependencies) are not already installed at the root directory of react-native, running ESLint could fail to resolve any required dependencies. In other words, there was an implicit dependency that react-native/yarn.lock would also contain any dependencies required by react-native/packages/eslint-config-react-native-community/yarn.lock.

With this change, running yarn from the root directory of react-native will also install any dependencies of @react-native-community/eslint-config, and it will also symlink react-native/node_modules/@react-native-community/eslint-config to ../../packages/eslint-config-react-native-community (meaning any local changes to the config will still be reflected during active development).

Changelog

[Internal]

Test Plan

Successfully install dependencies and run ESLint.

$ cd react-native
$ yarn
$ yarn lint

Successfully run Danger on #34401 (which would previously fail because @typescript-eslint/eslint-plugin could not be resolved from the root directory of react-native):

$ cd react-native/bots
$ yarn
$ node ./node_modules/.bin/danger pr https://github.com/facebook/react-native/pull/34401

[github-actions]

	Warnings
⚠️	🔒 package.json - Changes were made to package.json. This will require a manual import by a Facebook employee.

Generated by 🚫 dangerJS against cc8e243

[cortinico]

Love this <3

[yungsters]

Less special cases!

It's always a little bit scary because someone at some point in time thought this was a good idea. I could not find any reason why this was originally done, though, so… move fast and break things, I suppose. 😁

[yungsters]

Oh, actually… I found the reason in 3967635:

Note: We do not use eslint-config-react-native-community internally and it pulls in a lot of packages we don't need. It is part of the React Native repo because it is used in the RN app template but we may want to choose to move it out into a separate repo at some point.

Yeah… that's fine. We want these TypeScript dependencies installed now.

[facebook-github-bot]

@yungsters has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

[analysis-bot]

Platform	Engine	Arch	Size (bytes)	Diff
android	hermes	arm64-v8a	7,610,287	-132
android	hermes	armeabi-v7a	7,025,045	-137
android	hermes	x86	7,910,175	-141
android	hermes	x86_64	7,883,828	-136
android	jsc	arm64-v8a	9,489,076	-41
android	jsc	armeabi-v7a	8,266,718	-36
android	jsc	x86	9,426,549	-39
android	jsc	x86_64	10,019,314	-36

Base commit: ca1c3f9
Branch: main

[analysis-bot]

Platform	Engine	Arch	Size (bytes)	Diff
ios	-	universal	n/a	--

Base commit: ca1c3f9
Branch: main

[yungsters]

Actually, this is wrong. Due to how our repository is set up right now (to work with our internal codebase), this only has to be declared in react-native/repo-config/package.json (and it is already present there).

[rickhanlonii]

🎉

[react-native-bot]

This pull request was successfully merged by @yungsters in be8fe7a.

^{When will my fix make it into a release? | Upcoming Releases}