[RN][iOS][0.71] Fix flipper for Xcode 15.3 #43345
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
|
cipolleschi
force-pushed
the
cipolleschi/fix-flipper-0.71
branch
3 times, most recently
from
6f01766 to
caa42d1
Compare
cipolleschi
force-pushed
the
cipolleschi/fix-flipper-0.71
branch
from
caa42d1 to
2944ca6
Compare
|
I also bumped the podfile.lock |
pxpeterxu
added a commit
to wanderlog/react-native
that referenced
this pull request
Mar 7, 2024
pxpeterxu
added a commit
to wanderlog/react-native
that referenced
this pull request
Mar 9, 2024
|
@cipolleschi Do you have any estimated deadline for merging this PR? |
|
Can we get movement on this? 0.71 is within the support window but people using XCode 15.3 cannot build without this fix. |
|
Hi! Could you please take a look at this PR to get it merged quickly? I am an RN 0.71 user and I really need XCode 15.4 🥲 I'm always grateful for the contributions. |
hurali97
approved these changes
Apr 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Following #43335, we implemented the fix suggested here.
The rationale of applying this fix rather then releasing a new version of Flipper is because we will have to release Flipper
0.248.0, and the latest flipper version on Cocoapods is0.233.0(15 versions behind).Plus, we have to port the fix to 0.73 and 0.72 and bumping Flipper there would be a major pain and it might require more time and introduce other bugs we don't want.
Changelog
[iOS][Fixed] - Make 0.71 build with Xcode 15.3
Test Plan
Tested locally + CircleCI is green