Modal "avoidKeyboard" prop #52526
Open
Modal "avoidKeyboard" prop #52526
+38
−11
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D78010672 |
lironmosh
force-pushed
the
export-D78010672
branch
from
74fd7aa to
90f09ec
Compare
lironmosh
pushed a commit
to lironmosh/react-native
that referenced
this pull request
Jul 11, 2025
Summary: ## Changelog [iOS] [Added] - Modal "avoidKeyboard" prop ## The problem It seems like the default behavior is that in iOS the modal is not avoiding the keyboard, meaning that anywhere that there is a modal that can trigger the virtual keyboard, this issue can occour. ## The fix Addign support inside the "Modal" component using a new flag called "avoidKeyboard" which is implemented by conditionally wrapping the children of the modal with "KeyboardAvoidingView" with the needed attributes to cause the modal itself to avoid the keyboard to get the desired behavior. Reviewed By: bsalex Differential Revision: D78010672
Summary: Pull Request resolved: facebook#52526 ## Changelog [iOS] [Added] - Modal "avoidKeyboard" prop ## The problem It seems like the default behavior is that in iOS the modal is not avoiding the keyboard, meaning that anywhere that there is a modal that can trigger the virtual keyboard, this issue can occour. ## The fix Addign support inside the "Modal" component using a new flag called "avoidKeyboard" which is implemented by conditionally wrapping the children of the modal with "KeyboardAvoidingView" with the needed attributes to cause the modal itself to avoid the keyboard to get the desired behavior. Reviewed By: bsalex Differential Revision: D78010672
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D78010672 |
lironmosh
force-pushed
the
export-D78010672
branch
from
90f09ec to
c183ecb
Compare
Collaborator
|
This PR is stale because it has been open for 180 days with no activity. It will be closed in 7 days unless you comment on it or remove the "Stale" label. |
react-native-bot
added
the
Stale
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Changelog
[iOS] [Added] - Modal "avoidKeyboard" prop
The problem
It seems like the default behavior is that in iOS the modal is not avoiding the keyboard, meaning that anywhere that there is a modal that can trigger the virtual keyboard, this issue can occour.
The fix
Addign support inside the "Modal" component using a new flag called "avoidKeyboard" which is implemented by conditionally wrapping the children of the modal with "KeyboardAvoidingView" with the needed attributes to cause the modal itself to avoid the keyboard to get the desired behavior.
Reviewed By: bsalex
Differential Revision: D78010672