iOS: Add new configuration for `RCTDevMenu` #53505

coado · 2025-08-28T14:53:31Z

Summary:

Following the RFC, this PR adds new RCTDevMenu configuration and extends RCTReactNativeFactory API for passing it to the particular RCTHost. The RCTDevMenuConfiguration includes:

devMenuEnabled,
shakeGestureEnabled,
keyboardShortcutsEnabled

Changelog:

[IOS][ADDED] - Add new configuration for RCTDevMenu

Test Plan:

Tested with different configurations on RCTDevMenuConfiguration:

Click to view code

- (BOOL)application:(UIApplication *)application didFinishLaunchingWithOptions:(NSDictionary *)launchOptions
{
  self.reactNativeFactory = [[RCTReactNativeFactory alloc] initWithDelegate:self];
#if USE_OSS_CODEGEN
  self.dependencyProvider = [RCTAppDependencyProvider new];
#endif
  
  RCTDevMenuConfiguration *devMenuConfiguration = [[RCTDevMenuConfiguration alloc] initWithDevMenuEnabled:true shakeGestureEnabled:false keyboardShortcutsEnabled:false];

  [self.reactNativeFactory setDevMenuConfiguration:devMenuConfiguration];

  self.window = [[UIWindow alloc] initWithFrame:[UIScreen mainScreen].bounds];

  [self.reactNativeFactory startReactNativeWithModuleName:@"RNTesterApp"
                                                 inWindow:self.window
                                        initialProperties:[self prepareInitialProps]
                                            launchOptions:launchOptions];

  [[UNUserNotificationCenter currentNotificationCenter] setDelegate:self];

  return YES;
}

Run helloworld:

Saadnajmi · 2025-08-29T08:14:30Z

A diff we have internally at Microsoft is we expose RCTDevSetting's dataSource (which is private, but seems like it was meant to be public?) so that we can set our own custom one, which sets whether the dev menu is shown and other settings that way. I was considering upstreaming that change when I noticed this PR. Food for thought in case it's helpful / you wanna go that way.

See these two:

react-native/packages/react-native/React/CoreModules/RCTDevSettings.h

Line 47 in b02251e

- (instancetype)initWithDataSource:(id<RCTDevSettingsDataSource>)dataSource;

and

react-native/packages/react-native/React/CoreModules/RCTDevSettings.mm

Line 57 in b02251e

    
           @interface RCTDevSettingsUserDefaultsDataSource : NSObject <RCTDevSettingsDataSource>

coado · 2025-08-29T09:04:14Z

A diff we have internally at Microsoft is we expose RCTDevSetting's dataSource (which is private, but seems like it was meant to be public?) so that we can set our own custom one, which sets whether the dev menu is shown and other settings that way. I was considering upstreaming that change when I noticed this PR. Food for thought in case it's helpful / you wanna go that way.

See these two:

react-native/packages/react-native/React/CoreModules/RCTDevSettings.h

Line 47 in b02251e

- (instancetype)initWithDataSource:(id<RCTDevSettingsDataSource>)dataSource;

and

react-native/packages/react-native/React/CoreModules/RCTDevSettings.mm

Line 57 in b02251e

@interface RCTDevSettingsUserDefaultsDataSource : NSObject <RCTDevSettingsDataSource>

Hey, thanks for the suggestion. I think exposing RCTDevSettingsDataSource might be a bit out of scope for us. You can learn more about the changes we plan to make in RFC.

Saadnajmi · 2025-08-30T06:26:17Z

A diff we have internally at Microsoft is we expose RCTDevSetting's dataSource (which is private, but seems like it was meant to be public?) so that we can set our own custom one, which sets whether the dev menu is shown and other settings that way. I was considering upstreaming that change when I noticed this PR. Food for thought in case it's helpful / you wanna go that way.

See these two:

react-native/packages/react-native/React/CoreModules/RCTDevSettings.h

Line 47 in b02251e

- (instancetype)initWithDataSource:(id<RCTDevSettingsDataSource>)dataSource;

and

react-native/packages/react-native/React/CoreModules/RCTDevSettings.mm

Line 57 in b02251e

@interface RCTDevSettingsUserDefaultsDataSource : NSObject <RCTDevSettingsDataSource>

Hey, thanks for the suggestion. I think exposing RCTDevSettingsDataSource might be a bit out of scope for us. You can learn more about the changes we plan to make in RFC.

Ah, didn't see the RFC :) thanks!

packages/rn-tester/RNTester/AppDelegate.mm

packages/react-native/React/Base/RCTDevMenuConfigurationDecorator.mm

facebook-github-bot · 2025-09-04T14:42:39Z

@coado has imported this pull request. If you are a Meta employee, you can view this in D81684275.

facebook-github-bot · 2025-09-05T12:02:37Z

@coado has imported this pull request. If you are a Meta employee, you can view this in D81684275.

Summary: Following the [RFC](react-native-community/discussions-and-proposals#925), this PR adds new `RCTDevMenu` configuration and extends `RCTReactNativeFactory` API for passing it to the particular `RCTHost`. The `RCTDevMenuConfiguration` includes: - isDevMenuEnabled, - isShakeGestureEnabled, - areKeyboardShortcutsEnabled ## Changelog: [IOS][ADDED] - Add new configuration for `RCTDevMenu` <!-- Help reviewers and the release process by writing your own changelog entry. Pick one each for the category and type tags: [ANDROID|GENERAL|IOS|INTERNAL] [BREAKING|ADDED|CHANGED|DEPRECATED|REMOVED|FIXED|SECURITY] - Message For more details, see: https://reactnative.dev/contributing/changelogs-in-pull-requests Test Plan: Tested with different configurations on `RCTDevMenuConfiguration`: <details> <summary>Click to view code</summary> ```objc - (BOOL)application:(UIApplication *)application didFinishLaunchingWithOptions:(NSDictionary *)launchOptions { self.reactNativeFactory = [[RCTReactNativeFactory alloc] initWithDelegate:self]; #if USE_OSS_CODEGEN self.dependencyProvider = [RCTAppDependencyProvider new]; #endif RCTDevMenuConfiguration *devMenuConfiguration = [[RCTDevMenuConfiguration alloc] initWithDevMenuEnabled:true shakeGestureEnabled:false keyboardShortcutsEnabled:false]; [self.reactNativeFactory setDevMenuConfiguration:devMenuConfiguration]; self.window = [[UIWindow alloc] initWithFrame:[UIScreen mainScreen].bounds]; [self.reactNativeFactory startReactNativeWithModuleName:@"RNTesterApp" inWindow:self.window initialProperties:[self prepareInitialProps] launchOptions:launchOptions]; [[UNUserNotificationCenter currentNotificationCenter] setDelegate:self]; return YES; } ``` </details> Differential Revision: D81684275 Pulled By: coado

facebook-github-bot · 2025-09-15T09:43:31Z

@coado has exported this pull request. If you are a Meta employee, you can view the originating diff in D81684275.

facebook-github-bot · 2025-09-15T12:08:39Z

@coado has imported this pull request. If you are a Meta employee, you can view this in D81684275.

Summary: Following the [RFC](react-native-community/discussions-and-proposals#925), this PR adds new `RCTDevMenu` configuration and extends `RCTReactNativeFactory` API for passing it to the particular `RCTHost`. The `RCTDevMenuConfiguration` includes: - isDevMenuEnabled, - isShakeGestureEnabled, - areKeyboardShortcutsEnabled ## Changelog: [IOS][ADDED] - Add new configuration for `RCTDevMenu` <!-- Help reviewers and the release process by writing your own changelog entry. Pick one each for the category and type tags: [ANDROID|GENERAL|IOS|INTERNAL] [BREAKING|ADDED|CHANGED|DEPRECATED|REMOVED|FIXED|SECURITY] - Message For more details, see: https://reactnative.dev/contributing/changelogs-in-pull-requests Test Plan: Tested with different configurations on `RCTDevMenuConfiguration`: <details> <summary>Click to view code</summary> ```objc - (BOOL)application:(UIApplication *)application didFinishLaunchingWithOptions:(NSDictionary *)launchOptions { self.reactNativeFactory = [[RCTReactNativeFactory alloc] initWithDelegate:self]; #if USE_OSS_CODEGEN self.dependencyProvider = [RCTAppDependencyProvider new]; #endif RCTDevMenuConfiguration *devMenuConfiguration = [[RCTDevMenuConfiguration alloc] initWithDevMenuEnabled:true shakeGestureEnabled:false keyboardShortcutsEnabled:false]; [self.reactNativeFactory setDevMenuConfiguration:devMenuConfiguration]; self.window = [[UIWindow alloc] initWithFrame:[UIScreen mainScreen].bounds]; [self.reactNativeFactory startReactNativeWithModuleName:@"RNTesterApp" inWindow:self.window initialProperties:[self prepareInitialProps] launchOptions:launchOptions]; [[UNUserNotificationCenter currentNotificationCenter] setDelegate:self]; return YES; } ``` </details> Run helloworld: <img src="https://github.com/user-attachments/assets/16c35176-6fbe-498c-96fd-a0fe988a5e3c" alt="hello-world-screenshot" width="300"> Differential Revision: D81684275 Pulled By: coado

facebook-github-bot · 2025-09-24T14:49:55Z

@coado has exported this pull request. If you are a Meta employee, you can view the originating diff in D81684275.

facebook-github-bot · 2025-09-25T08:31:57Z

@coado has imported this pull request. If you are a Meta employee, you can view this in D81684275.

Summary: Following the [RFC](react-native-community/discussions-and-proposals#925), this PR adds new `RCTDevMenu` configuration and extends `RCTReactNativeFactory` API for passing it to the particular `RCTHost`. The `RCTDevMenuConfiguration` includes: - isDevMenuEnabled, - isShakeGestureEnabled, - areKeyboardShortcutsEnabled ## Changelog: [IOS][ADDED] - Add new configuration for `RCTDevMenu` <!-- Help reviewers and the release process by writing your own changelog entry. Pick one each for the category and type tags: [ANDROID|GENERAL|IOS|INTERNAL] [BREAKING|ADDED|CHANGED|DEPRECATED|REMOVED|FIXED|SECURITY] - Message For more details, see: https://reactnative.dev/contributing/changelogs-in-pull-requests Test Plan: Tested with different configurations on `RCTDevMenuConfiguration`: <details> <summary>Click to view code</summary> ```objc - (BOOL)application:(UIApplication *)application didFinishLaunchingWithOptions:(NSDictionary *)launchOptions { self.reactNativeFactory = [[RCTReactNativeFactory alloc] initWithDelegate:self]; #if USE_OSS_CODEGEN self.dependencyProvider = [RCTAppDependencyProvider new]; #endif RCTDevMenuConfiguration *devMenuConfiguration = [[RCTDevMenuConfiguration alloc] initWithDevMenuEnabled:true shakeGestureEnabled:false keyboardShortcutsEnabled:false]; [self.reactNativeFactory setDevMenuConfiguration:devMenuConfiguration]; self.window = [[UIWindow alloc] initWithFrame:[UIScreen mainScreen].bounds]; [self.reactNativeFactory startReactNativeWithModuleName:@"RNTesterApp" inWindow:self.window initialProperties:[self prepareInitialProps] launchOptions:launchOptions]; [[UNUserNotificationCenter currentNotificationCenter] setDelegate:self]; return YES; } ``` </details> Run helloworld: <img src="https://github.com/user-attachments/assets/16c35176-6fbe-498c-96fd-a0fe988a5e3c" alt="hello-world-screenshot" width="300"> Differential Revision: D81684275 Pulled By: coado

facebook-github-bot · 2025-09-25T11:42:43Z

@coado has exported this pull request. If you are a Meta employee, you can view the originating diff in D81684275.

Summary: Following the [RFC](react-native-community/discussions-and-proposals#925), this PR adds new `RCTDevMenu` configuration and extends `RCTReactNativeFactory` API for passing it to the particular `RCTHost`. The `RCTDevMenuConfiguration` includes: - isDevMenuEnabled, - isShakeGestureEnabled, - areKeyboardShortcutsEnabled ## Changelog: [IOS][ADDED] - Add new configuration for `RCTDevMenu` <!-- Help reviewers and the release process by writing your own changelog entry. Pick one each for the category and type tags: [ANDROID|GENERAL|IOS|INTERNAL] [BREAKING|ADDED|CHANGED|DEPRECATED|REMOVED|FIXED|SECURITY] - Message For more details, see: https://reactnative.dev/contributing/changelogs-in-pull-requests Test Plan: Tested with different configurations on `RCTDevMenuConfiguration`: <details> <summary>Click to view code</summary> ```objc - (BOOL)application:(UIApplication *)application didFinishLaunchingWithOptions:(NSDictionary *)launchOptions { self.reactNativeFactory = [[RCTReactNativeFactory alloc] initWithDelegate:self]; #if USE_OSS_CODEGEN self.dependencyProvider = [RCTAppDependencyProvider new]; #endif RCTDevMenuConfiguration *devMenuConfiguration = [[RCTDevMenuConfiguration alloc] initWithDevMenuEnabled:true shakeGestureEnabled:false keyboardShortcutsEnabled:false]; [self.reactNativeFactory setDevMenuConfiguration:devMenuConfiguration]; self.window = [[UIWindow alloc] initWithFrame:[UIScreen mainScreen].bounds]; [self.reactNativeFactory startReactNativeWithModuleName:@"RNTesterApp" inWindow:self.window initialProperties:[self prepareInitialProps] launchOptions:launchOptions]; [[UNUserNotificationCenter currentNotificationCenter] setDelegate:self]; return YES; } ``` </details> Run helloworld: <img src="https://github.com/user-attachments/assets/16c35176-6fbe-498c-96fd-a0fe988a5e3c" alt="hello-world-screenshot" width="300"> Differential Revision: D81684275 Pulled By: coado

facebook-github-bot · 2025-09-25T13:53:49Z

@coado has exported this pull request. If you are a Meta employee, you can view the originating diff in D81684275.

Summary: Following the [RFC](react-native-community/discussions-and-proposals#925), this PR adds new `RCTDevMenu` configuration and extends `RCTReactNativeFactory` API for passing it to the particular `RCTHost`. The `RCTDevMenuConfiguration` includes: - isDevMenuEnabled, - isShakeGestureEnabled, - areKeyboardShortcutsEnabled ## Changelog: [IOS][ADDED] - Add new configuration for `RCTDevMenu` <!-- Help reviewers and the release process by writing your own changelog entry. Pick one each for the category and type tags: [ANDROID|GENERAL|IOS|INTERNAL] [BREAKING|ADDED|CHANGED|DEPRECATED|REMOVED|FIXED|SECURITY] - Message For more details, see: https://reactnative.dev/contributing/changelogs-in-pull-requests Test Plan: Tested with different configurations on `RCTDevMenuConfiguration`: <details> <summary>Click to view code</summary> ```objc - (BOOL)application:(UIApplication *)application didFinishLaunchingWithOptions:(NSDictionary *)launchOptions { self.reactNativeFactory = [[RCTReactNativeFactory alloc] initWithDelegate:self]; #if USE_OSS_CODEGEN self.dependencyProvider = [RCTAppDependencyProvider new]; #endif RCTDevMenuConfiguration *devMenuConfiguration = [[RCTDevMenuConfiguration alloc] initWithDevMenuEnabled:true shakeGestureEnabled:false keyboardShortcutsEnabled:false]; [self.reactNativeFactory setDevMenuConfiguration:devMenuConfiguration]; self.window = [[UIWindow alloc] initWithFrame:[UIScreen mainScreen].bounds]; [self.reactNativeFactory startReactNativeWithModuleName:@"RNTesterApp" inWindow:self.window initialProperties:[self prepareInitialProps] launchOptions:launchOptions]; [[UNUserNotificationCenter currentNotificationCenter] setDelegate:self]; return YES; } ``` </details> Run helloworld: <img src="https://github.com/user-attachments/assets/16c35176-6fbe-498c-96fd-a0fe988a5e3c" alt="hello-world-screenshot" width="300"> Differential Revision: D81684275 Pulled By: coado

facebook-github-bot · 2025-09-25T14:16:28Z

@coado has exported this pull request. If you are a Meta employee, you can view the originating diff in D81684275.

Summary: Following the [RFC](react-native-community/discussions-and-proposals#925), this PR adds new `RCTDevMenu` configuration and extends `RCTReactNativeFactory` API for passing it to the particular `RCTHost`. The `RCTDevMenuConfiguration` includes: - isDevMenuEnabled, - isShakeGestureEnabled, - areKeyboardShortcutsEnabled ## Changelog: [IOS][ADDED] - Add new configuration for `RCTDevMenu` <!-- Help reviewers and the release process by writing your own changelog entry. Pick one each for the category and type tags: [ANDROID|GENERAL|IOS|INTERNAL] [BREAKING|ADDED|CHANGED|DEPRECATED|REMOVED|FIXED|SECURITY] - Message For more details, see: https://reactnative.dev/contributing/changelogs-in-pull-requests Test Plan: Tested with different configurations on `RCTDevMenuConfiguration`: <details> <summary>Click to view code</summary> ```objc - (BOOL)application:(UIApplication *)application didFinishLaunchingWithOptions:(NSDictionary *)launchOptions { self.reactNativeFactory = [[RCTReactNativeFactory alloc] initWithDelegate:self]; #if USE_OSS_CODEGEN self.dependencyProvider = [RCTAppDependencyProvider new]; #endif RCTDevMenuConfiguration *devMenuConfiguration = [[RCTDevMenuConfiguration alloc] initWithDevMenuEnabled:true shakeGestureEnabled:false keyboardShortcutsEnabled:false]; [self.reactNativeFactory setDevMenuConfiguration:devMenuConfiguration]; self.window = [[UIWindow alloc] initWithFrame:[UIScreen mainScreen].bounds]; [self.reactNativeFactory startReactNativeWithModuleName:@"RNTesterApp" inWindow:self.window initialProperties:[self prepareInitialProps] launchOptions:launchOptions]; [[UNUserNotificationCenter currentNotificationCenter] setDelegate:self]; return YES; } ``` </details> Run helloworld: <img src="https://github.com/user-attachments/assets/16c35176-6fbe-498c-96fd-a0fe988a5e3c" alt="hello-world-screenshot" width="300"> Differential Revision: D81684275 Pulled By: coado

facebook-github-bot · 2025-09-29T10:07:00Z

@coado has exported this pull request. If you are a Meta employee, you can view the originating diff in D81684275.

react-native-bot · 2025-10-01T09:46:27Z

This pull request was successfully merged by @coado in 29d5aa5

^{When will my fix make it into a release? | How to file a pick request?}

facebook-github-bot · 2025-10-01T09:46:31Z

@coado merged this pull request in 29d5aa5.

meta-cla bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Aug 28, 2025

facebook-github-bot added p: Software Mansion Partner: Software Mansion Partner p: Facebook Partner: Facebook labels Aug 28, 2025

j-piasecki reviewed Sep 3, 2025

View reviewed changes

packages/rn-tester/RNTester/AppDelegate.mm Outdated Show resolved Hide resolved

packages/react-native/React/Base/RCTDevMenuConfigurationDecorator.mm Show resolved Hide resolved

coado marked this pull request as ready for review September 4, 2025 15:10

coado force-pushed the dev-menu branch from c8717e7 to 56c7a32 Compare September 15, 2025 09:43

facebook-github-bot added fb-exported meta-exported labels Sep 15, 2025

coado force-pushed the dev-menu branch from cb706f3 to 58055d2 Compare September 24, 2025 14:49

coado force-pushed the dev-menu branch from c39759b to ec19b16 Compare September 25, 2025 11:42

coado force-pushed the dev-menu branch from ec19b16 to 9c87d0f Compare September 25, 2025 13:53

coado force-pushed the dev-menu branch from 9c87d0f to c76bf3e Compare September 25, 2025 14:16

coado force-pushed the dev-menu branch from c76bf3e to 03a162e Compare September 29, 2025 10:06

facebook-github-bot closed this in 29d5aa5 Oct 1, 2025

react-native-bot added the Merged This PR has been merged. label Oct 1, 2025

Uh oh!

iOS: Add new configuration for RCTDevMenu #53505

iOS: Add new configuration for RCTDevMenu #53505

Uh oh!

Conversation

coado commented Aug 28, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary:

Changelog:

Test Plan:

Uh oh!

Saadnajmi commented Aug 29, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

coado commented Aug 29, 2025

Uh oh!

Saadnajmi commented Aug 30, 2025

Uh oh!

Uh oh!

Uh oh!

facebook-github-bot commented Sep 4, 2025

Uh oh!

facebook-github-bot commented Sep 5, 2025

Uh oh!

facebook-github-bot commented Sep 15, 2025

Uh oh!

facebook-github-bot commented Sep 15, 2025

Uh oh!

facebook-github-bot commented Sep 24, 2025

Uh oh!

facebook-github-bot commented Sep 25, 2025

Uh oh!

facebook-github-bot commented Sep 25, 2025

Uh oh!

facebook-github-bot commented Sep 25, 2025

Uh oh!

facebook-github-bot commented Sep 25, 2025

Uh oh!

facebook-github-bot commented Sep 29, 2025

Uh oh!

react-native-bot commented Oct 1, 2025

Uh oh!

facebook-github-bot commented Oct 1, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

iOS: Add new configuration for `RCTDevMenu` #53505

iOS: Add new configuration for `RCTDevMenu` #53505

coado commented Aug 28, 2025 •

edited

Loading

Saadnajmi commented Aug 29, 2025 •

edited

Loading