Skip to content

Conversation

ANTI-Tony
Copy link

@ANTI-Tony ANTI-Tony commented Oct 4, 2025

Summary

Fixes #54056

When a Text component has padding, onPress events were not triggered when clicking in the padding area on iOS with the new architecture (Fabric) enabled.

Changes

Modified getEventEmitterWithAttributeString in RCTTextLayoutManager.mm to fix overly strict hit testing logic.

The previous implementation rejected touch points where fraction == 0 or fraction == 1, which occurs when clicking in padding areas. This fix removes the fraction check and allows any valid character index within the text storage to return an event emitter.

Test Plan

  1. Create a Text component with padding and onPress handler
  2. Click on the padding area (not the text itself)
  3. Verify that onPress is triggered

Before: Only text content was clickable
After: Both padding and text content are clickable

Platforms

  • iOS (Fabric)
  • Android (not affected by this issue)

Changelog

[IOS][FIXED] - Fix Text component padding touch area on iOS with Fabric enabled

When a Text component has padding, onPress events were not triggered
when clicking in the padding area on iOS. This was caused by overly
strict hit testing logic in getEventEmitterWithAttributeString.

The previous logic rejected touch points where fraction == 0 or 1,
which occurs when clicking in padding areas. This fix removes the
fraction check and allows any valid character index within the text
storage to return an event emitter.

Fixes facebook#54056
Copy link

meta-cla bot commented Oct 4, 2025

Hi @ANTI-Tony!

Thank you for your pull request and welcome to our community.

Action Required

In order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you.

Process

In order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with CLA signed. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.

If you have received this in error or have any questions, please contact us at [email protected]. Thanks!

@react-native-bot
Copy link
Collaborator

Fails
🚫

📋 Missing Changelog - Please add a Changelog to your PR description. See Changelog format

Generated by 🚫 dangerJS against 3f3ed7e

Copy link

meta-cla bot commented Oct 4, 2025

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Meta Open Source project. Thanks!

@meta-cla meta-cla bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Oct 4, 2025
@facebook-github-bot facebook-github-bot added the Shared with Meta Applied via automation to indicate that an Issue or Pull Request has been shared with the team. label Oct 4, 2025
@javache
Copy link
Member

javache commented Oct 6, 2025

Could you add a test-case to RNTester to demonstrate this issue?

Could you also test what happens when the text view is flattened in a much bigger container. Are we definitely not receiving touches outside of the textview's bounds?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. Shared with Meta Applied via automation to indicate that an Issue or Pull Request has been shared with the team.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Padding on Text results in incorrect bounding box for press events
4 participants