Fix Text component padding touch area on iOS (Fabric) #54064
+6
−6
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #54056
When a Text component has padding,
onPress
events were not triggered when clicking in the padding area on iOS with the new architecture (Fabric) enabled.Changes
Modified
getEventEmitterWithAttributeString
inRCTTextLayoutManager.mm
to fix overly strict hit testing logic.The previous implementation rejected touch points where
fraction == 0
orfraction == 1
, which occurs when clicking in padding areas. This fix removes the fraction check and allows any valid character index within the text storage to return an event emitter.Test Plan
Before: Only text content was clickable
After: Both padding and text content are clickable
Platforms
Changelog
[IOS][FIXED] - Fix Text component padding touch area on iOS with Fabric enabled