Updating frontend assets to add header for open-in-editor sources panel devtools button #54927
+3
−3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…el devtools button
meta-cla
bot
added
the
CLA Signed
facebook-github-bot
added
the
Shared with Meta
|
@emily8rown has imported this pull request. If you are a Meta employee, you can view this in D89464184. |
| @generated SignedSource<<3e785aa8e1e511007bb7bc59210a9a1a>> | ||
| Git revision: c85f7e933aa685da64ee73e398bf06d33d9d2f3c | ||
| @generated SignedSource<<ed580785f8afa314ec8cc43c7523f469>> | ||
| Git revision: 1f006e22bfad4d66df4786d6d775c15101c66e5d |
|
@emily8rown merged this pull request in d35904d. |
Collaborator
|
This pull request was successfully merged by @emily8rown in d35904d When will my fix make it into a release? | How to file a pick request? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Updating front end assets for this pr
The "Open in Editor" button in the Sources tab was failing with a 400 Bad Request error. This was because the openStackFrameInEditor request was missing the Content-Type header. Added the appropriate content type header to fix the request.
Changelog:
[GENERAL] [FIXED] - Fix "Open in Editor" button in Sources tab returning 400 Bad Request
Test Plan:
Open React Native DevTools
Go to Sources tab
Click "Open in Editor" button on a stack frame
Verify the file opens in the editor without a 400 error